You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 13:18:40 UTC
[GitHub] [kafka] ijuma commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys
ijuma commented on a change in pull request #10978:
URL: https://github.com/apache/kafka/pull/10978#discussion_r665362085
##########
File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java
##########
@@ -65,7 +65,7 @@ protected boolean authenticate(String username, char[] password) throws IOExcept
String expectedPassword = JaasContext.configEntryOption(jaasConfigEntries,
JAAS_USER_PREFIX + username,
PlainLoginModule.class.getName());
- return expectedPassword != null && Arrays.equals(password, expectedPassword.toCharArray());
+ return expectedPassword != null && Utils.isEqual(password, expectedPassword.toCharArray());
Review comment:
Hmm, if we convert arrays to bytes, we need to be careful. If the arrays have different sizes, then the operation is not constant time.
##########
File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java
##########
@@ -65,7 +65,7 @@ protected boolean authenticate(String username, char[] password) throws IOExcept
String expectedPassword = JaasContext.configEntryOption(jaasConfigEntries,
JAAS_USER_PREFIX + username,
PlainLoginModule.class.getName());
- return expectedPassword != null && Arrays.equals(password, expectedPassword.toCharArray());
+ return expectedPassword != null && Utils.isEqual(password, expectedPassword.toCharArray());
Review comment:
Hmm, if we convert arrays to bytes, we need to be careful. If the arrays have different sizes, then the operation is not constant time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org