You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2023/11/16 03:39:15 UTC
[PR] [MINOR] Modified description to include missing trigger strategy [hudi]
voonhous opened a new pull request, #10114:
URL: https://github.com/apache/hudi/pull/10114
### Change Logs
In https://github.com/apache/hudi/pull/6144, a new compaction trigger strategy was added named `NUM_COMMITS_AFTER_LAST_REQUEST`, org.apache.hudi.table.action.compact.CompactionTriggerStrategy.
However, the FlinkOptions description as never updated to include this new trigger strategy. Adding it in so that configs page on doc-site will reflect this trigger strategy for completeness.
TODO:
Might need to do some refactoring to centralise these common config so that we do not have to worry about these de-sync in the future. Might also make it easier for testing.
### Impact
None
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10114:
URL: https://github.com/apache/hudi/pull/10114#issuecomment-1813884877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941",
"triggerID" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5152ea66bd6f4a3c3f506bfe051ef4122973e908 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10114:
URL: https://github.com/apache/hudi/pull/10114#issuecomment-1813954875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941",
"triggerID" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"triggerType" : "PUSH"
}, {
"hash" : "06b93d66dfcbb9fddd38065d442ca7462cf6d3be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06b93d66dfcbb9fddd38065d442ca7462cf6d3be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5152ea66bd6f4a3c3f506bfe051ef4122973e908 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941)
* 06b93d66dfcbb9fddd38065d442ca7462cf6d3be UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #10114:
URL: https://github.com/apache/hudi/pull/10114#discussion_r1395274432
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -41,6 +41,7 @@
import org.apache.hudi.keygen.constant.KeyGeneratorType;
import org.apache.hudi.sink.overwrite.PartitionOverwriteMode;
import org.apache.hudi.table.action.cluster.ClusteringPlanPartitionFilterMode;
+import org.apache.hudi.table.action.compact.CompactionTriggerStrategy;
import org.apache.hudi.util.ClientIds;
Review Comment:
My bad, was doing some debugging and forgot to remove it.
Will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10114:
URL: https://github.com/apache/hudi/pull/10114#issuecomment-1813755365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941",
"triggerID" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5152ea66bd6f4a3c3f506bfe051ef4122973e908 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10114:
URL: https://github.com/apache/hudi/pull/10114#issuecomment-1813750459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5152ea66bd6f4a3c3f506bfe051ef4122973e908 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10114:
URL: https://github.com/apache/hudi/pull/10114#discussion_r1395272032
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -41,6 +41,7 @@
import org.apache.hudi.keygen.constant.KeyGeneratorType;
import org.apache.hudi.sink.overwrite.PartitionOverwriteMode;
import org.apache.hudi.table.action.cluster.ClusteringPlanPartitionFilterMode;
+import org.apache.hudi.table.action.compact.CompactionTriggerStrategy;
import org.apache.hudi.util.ClientIds;
Review Comment:
Why the importation of the class is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10114:
URL: https://github.com/apache/hudi/pull/10114#issuecomment-1813964379
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941",
"triggerID" : "5152ea66bd6f4a3c3f506bfe051ef4122973e908",
"triggerType" : "PUSH"
}, {
"hash" : "06b93d66dfcbb9fddd38065d442ca7462cf6d3be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20946",
"triggerID" : "06b93d66dfcbb9fddd38065d442ca7462cf6d3be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5152ea66bd6f4a3c3f506bfe051ef4122973e908 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20941)
* 06b93d66dfcbb9fddd38065d442ca7462cf6d3be Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20946)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10114:
URL: https://github.com/apache/hudi/pull/10114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Modified description to include missing trigger strategy [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #10114:
URL: https://github.com/apache/hudi/pull/10114#discussion_r1395275760
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -41,6 +41,7 @@
import org.apache.hudi.keygen.constant.KeyGeneratorType;
import org.apache.hudi.sink.overwrite.PartitionOverwriteMode;
import org.apache.hudi.table.action.cluster.ClusteringPlanPartitionFilterMode;
+import org.apache.hudi.table.action.compact.CompactionTriggerStrategy;
import org.apache.hudi.util.ClientIds;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org