You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sahilrulzs <gi...@git.apache.org> on 2015/12/22 07:51:44 UTC
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
GitHub user sahilrulzs opened a pull request:
https://github.com/apache/cordova-osx/pull/29
Support for multi-dimensional js array/objects
Previous implementation was not parsing multi-dimensional JS array > object properly. Replacing it with webkit javascriptCore implementation solved it. (From OSX 10.5)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sahilrulzs/cordova-osx patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit e18ff29aa8e97c9cabc256c20b856baec66007f4
Author: Sahil Bhardwaj <sa...@gmail.com>
Date: 2015-12-22T06:51:09Z
Support for multi-dimensional js array/objects
Previous implementation was not parsing multi-dimensional JS array > object properly. Replacing it with webkit javascriptCore implementation solved it. (From OSX 10.5)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by spirylics <gi...@git.apache.org>.
Github user spirylics commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-181573279
It should be 'JavaScriptCore/JavaScriptCore.h' instead of 'JavascriptCore/JavascriptCore.h'. (uppercase S)
It doesn't work with case sensitive file system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by sahilrulzs <gi...@git.apache.org>.
Github user sahilrulzs commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-169104897
Sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-osx/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-169758462
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-181955368
thanks @spirylics for pointing this out. can you create a new issue in https://issues.apache.org/jira/browse/CB ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by spirylics <gi...@git.apache.org>.
Github user spirylics commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-180792552
Somebody has this issue : ../CDVBridge.m:21:9: fatal error: 'JavascriptCore/JavascriptCore.h' file not found
[exec] #import <JavascriptCore/JavascriptCore.h>
With OSX 10.11.13, cordova 6.0.0, Xcode 7.2.1 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-169104634
thanks for the PR. can you open a proper jira issue and a test case that illustrates the behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by sahilrulzs <gi...@git.apache.org>.
Github user sahilrulzs commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-169554517
Here you go: https://issues.apache.org/jira/browse/CB-10308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by spirylics <gi...@git.apache.org>.
Github user spirylics commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-181967238
@tripodsan I've made a pullrequest : https://github.com/apache/cordova-osx/pull/30
Is it sufficient ?
Since several weeks, I use case sensitive and I have no problem except this. Case sensitive can be interesting when you dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...
Posted by SahilBh <gi...@git.apache.org>.
Github user SahilBh commented on the pull request:
https://github.com/apache/cordova-osx/pull/29#issuecomment-181445940
JavascriptCore is an framework present on mac os just like webkit. See here: http://www.steamclock.com/blog/2013/05/apple-objective-c-javascript-bridge/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org