You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/09 15:22:27 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #21770: More Jira -> Issues doc updates

Abacn commented on code in PR #21770:
URL: https://github.com/apache/beam/pull/21770#discussion_r893645208


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -5,7 +5,7 @@
 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
 
  - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- - [ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
+ - [ ] Mention the appropriate issue in your description (for example: "addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #<ISSUE NUMBER>" instead.

Review Comment:
   "automatically close ... comment "fixes #<ISSUE NUMBER>" That's nice. Is this already implemented?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org