You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2012/10/29 23:21:11 UTC

[jira] [Comment Edited] (CASSANDRA-4865) Off-heap bloom filters

    [ https://issues.apache.org/jira/browse/CASSANDRA-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486429#comment-13486429 ] 

Vijay edited comment on CASSANDRA-4865 at 10/29/12 10:20 PM:
-------------------------------------------------------------

Attached patch includes the nit and updated tests.

re-ran the test on 32 cores and shows bigger diffrence.
||Open BS set's|Open BS get's|Open BS clear's|Offheap BS set's|Offheap BS get's|Offheap BS clear's|
||593|495|658|408|132|392|
||606|479|749|394|130|556|
||542|452|736|394|130|554|
||543|460|736|395|129|555|
||542|452|736|391|129|554|
||541|465|735|391|129|555|
||542|454|737|392|129|555|
||541|452|736|391|130|554|
||542|452|735|391|129|554|
||542|452|736|391|130|554|
||542|519|736|391|130|554|

ran stress just for fun
before: aprox 2750
after: aprox 2800

Its a big win for a small change i guess :)
                
      was (Author: vijay2win@yahoo.com):
    Attached patch includes the nit and updated tests.

re-ran the test on 32 cores and shows bigger diffrence.

||593|495|658|408|132|392|
||606|479|749|394|130|556|
||542|452|736|394|130|554|
||543|460|736|395|129|555|
||542|452|736|391|129|554|
||541|465|735|391|129|555|
||542|454|737|392|129|555|
||541|452|736|391|130|554|
||542|452|735|391|129|554|
||542|452|736|391|130|554|
||542|519|736|391|130|554|

ran stress just for fun
before: aprox 2750
after: aprox 2800

Its a big win for a small change i guess :)
                  
> Off-heap bloom filters
> ----------------------
>
>                 Key: CASSANDRA-4865
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4865
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>             Fix For: 1.2.1
>
>         Attachments: 0001-CASSANDRA-4865.patch, 0001-CASSANDRA-4865-v2.patch
>
>
> Bloom filters are the major user of heap as dataset grows.  It's probably worth it to move these off heap.  No extra refcounting needs to be done since we already refcount SSTableReader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira