You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2017/02/15 09:01:41 UTC
[jira] [Comment Edited] (QPID-7622) Separate Qpid Broker for Java
and 0-x JMS Client in source tree
[ https://issues.apache.org/jira/browse/QPID-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857830#comment-15857830 ]
Keith Wall edited comment on QPID-7622 at 2/15/17 9:01 AM:
-----------------------------------------------------------
Outstanding items - this list is not complete.
Client
* The refactoring of QPID-7532 introduce an API change in AMQException. Some tests in the systests module make assertions about the error code. The API change required an ugly workaround (AbstractACLTestCase#assertAMQException) so they remain compatible with both qpid-client-6.1.1 and qpid-client-6.3.0-SNAPSHOT.
* AmqpManagementTest don't run with the qpid-client-6.1.1. There is currently an ugly version based exclusion in the test. I suspect the client changes made by QPID-7533 were required to allow the client to process the special management addresses.
* * LICENSE/README updates
Broker:
* Client transport stack needs to be removed.
* Client SASL related classes
* 0-10 Connection pulls in many client classes such as ClientProperties. Connection will need to be refactored so that its old 'client' responsibilities are removed.
* Would like to move the 0-8/0-10 protocol classes from broker-core to the appropriate plugins. The following stands in the way
** DTX registry and friends are currently in terms of 0-10 protocol objects
** The AMQP 1.0 protocol layer uses BBDecoder (0-10) and TypedBytesContentReader (0-8)
* LICENSE/README updates
was (Author: k-wall):
Outstanding items - this list is not complete.
Client
* The refactoring of QPID-7532 introduce an API change in AMQException. Some tests in the systests module make assertions about the error code. The API change required an ugly workaround (AbstractACLTestCase#assertAMQException) so they remain compatible with both qpid-client-6.1.1 and qpid-client-6.3.0-SNAPSHOT.
* AmqpManagementTest don't run with the qpid-client-6.1.1. There is currently an ugly version based exclusion in the test. I suspect the client changes made by QPID-7533 were required to allow the client to process the special management addresses.
Broker:
* Client transport stack needs to be removed.
* Client SASL related classes
* 0-10 Connection pulls in many client classes such as ClientProperties. Connection will need to be refactored so that its old 'client' responsibilities are removed.
* Would like to move the 0-8/0-10 protocol classes from broker-core to the appropriate plugins. The following stands in the way
** DTX registry and friends are currently in terms of 0-10 protocol objects
** The AMQP 1.0 protocol layer uses BBDecoder (0-10) and TypedBytesContentReader (0-8)
> Separate Qpid Broker for Java and 0-x JMS Client in source tree
> ---------------------------------------------------------------
>
> Key: QPID-7622
> URL: https://issues.apache.org/jira/browse/QPID-7622
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Reporter: Keith Wall
> Fix For: qpid-java-7.0
>
>
> As discussed here:
> http://qpid.2158936.n2.nabble.com/DISCUSS-Drop-the-AMQP-0-x-client-from-the-Qpid-for-Java-7-0-release-td7657770.html
> The proposal is to move the code and documentation that comprises the 0-x client to its own SVN root:
> https://svn.apache.org/repos/asf/qpid/qpid-jms-0-x
> The Java Broker and integration tests suites will remain at: https://svn.apache.org/repos/asf/qpid/qpid-java
> Maven dependencies will be used to pull in the appropriate 0-x client for integration testing purposes (as we already do with the Qpid JMS Client).
> The {{qpid-common}} module (and maven release artefact) will be eliminated.
> * Classes that the Broker requires will be moved into the class hierarchy of the existing plugin modules {{amqp-0-10-protocol}} and {{amqp-0-8-protocol}} e.g. {{org/apache/qpid/server/protocol/vx_y}}.* There is some generic code used by many modules such as BindingURL whose copy shall live in broker-core.
> * Code that the 0-x client requires will be copied into the client module. The package names will be unchanged.
> This will allow the Broker and 0-x Client to co-exist in the same JVM without class loading collision. Class movements will be organised in such a way to preserve SVN history.
> The structure of trunk qpid-jms-0-x will look like:
> - qpid-jms-0-x
> + client
> + example
> + jaa
> + example
> + ra
> + docs
> + jms-client-0-10
> + jms-client-0-8
> There will need to be a new parent POM.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org