You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alan Shaw (JIRA)" <ji...@apache.org> on 2011/02/07 20:36:57 UTC
[jira] Created: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
---------------------------------------------------------------------------------------------------------------------
Key: WICKET-3433
URL: https://issues.apache.org/jira/browse/WICKET-3433
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Reporter: Alan Shaw
Attachments: html5boilerplate.ui.wicket.parsefail.zip
I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
The first lines of the boilerplate html look like this:
<!doctype html>
<!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
<!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
<!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
<!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
<!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996747#comment-12996747 ]
Juergen Donnerstag commented on WICKET-3433:
--------------------------------------------
Hi Pedro,
few comments to your patch
- you "fixed" a test case by properly closing the <link> tag. Though it is proper XHTML now, HTML and most browsers did allow that inaccuracy, and we supported it as well. Introducing your patch means it no long works if markup contains conditional comments => That will be a difficult to find problem for user I guess
- since you are skipping all markup elements in HtmlHandler between the comment open and the close tag, no wicket components (manual or automatic ones) are allowed anymore in the markup embraced by the conditional. Something we used to support (see SimplePage_12.html). <link href="some.css"> which are common in between conditional comment e.g. will be affected => if we want to go down that road, than we need to properly communicate that limitation to our users.
Juergen
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-3433:
-------------------------------------
Assignee: Juergen Donnerstag
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009052#comment-13009052 ]
Juergen Donnerstag commented on WICKET-3433:
--------------------------------------------
Hi Pedro,
I didn't mean to give you a hard time. That's why I wrote my last comment. Though re-reading it, it says nothing about "hold off until I'm finished". Sorry for that.
I took a look at you patch. I think a little bit more tweaking to the framework - compared to the dedicated comment handling code - is necessary to make the markup filters more versatile.
Juergen
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WICKET-3433) Wicket parses HTML
inside IE conditional comments when they appear between the doctype
declaration and the tag
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991878#comment-12991878 ]
Alan Shaw edited comment on WICKET-3433 at 2/8/11 10:03 AM:
------------------------------------------------------------
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid htm to the browser.
was (Author: _alanshaw):
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the faststart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid htm to the browser.
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993878#comment-12993878 ]
Juergen Donnerstag commented on WICKET-3433:
--------------------------------------------
I find it difficult to imagine how Wicket could handle possibilities. Pedro is right in how Wicket will see the markup once loaded. It'll be like
<html>
<html>
<html>
<html>
<html>
Since Wicket validates that for every open tag, there is a close tag as well, Wicket complains about the missing </html> tags in your original example. And for the browser to be happy you need add what Pedro has suggested.
Now what would Wicket need to do in order to understand that use case: Wicket needs to validate that each body of the conditional leaves the very same open tag behind. In theory that could be done though a bit of work.
But it's not as simple as one my think. E.g. what is the rule that 2+ conditional tag belong to a group? I'd guess only "empty" raw markup between <![endif]> and the next <!--[if...>. But if the next conditional leaves different open tags behind, it should not be part of that group, right? => increase in complexity
<!--[if ..IE7...]> body AAAA <![endif]>
<!--[if ..IE7...]> body BBBB by purpose <![endif]>
If your conditional body for whatever reason gets a Component attached (either by the user or automatically by Wicket), than you'll need all the close tags. Otherwise the render process will fail.
May be we can't handle all possible scenarios, but improve a bit. An additional IMarkupFilter would be needed. I'm happy to review it if someone would provide the code.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WICKET-3433) Wicket parses HTML
inside IE conditional comments when they appear between the doctype
declaration and the tag
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991878#comment-12991878 ]
Alan Shaw edited comment on WICKET-3433 at 2/8/11 10:03 AM:
------------------------------------------------------------
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid html to the browser.
was (Author: _alanshaw):
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid htm to the browser.
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433.patch
Patch suporting the related usecase and Downlevel-revealed Conditional Comments as well
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: (was: WICKET-3433.patch)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008956#comment-13008956 ]
Pedro Santos commented on WICKET-3433:
--------------------------------------
Nice, I think I did that in the patch, the new filter fully handling conditional comment logic is the ConditionalCommentFilter
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3433:
------------------------------------
Attachment: programmatic-way.tgz
Attaching the fixed quickstart provider by Christian.
@Christian: its your turn again. Please create a wiki page, describe the use case and paste the relevant snippets :-)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, programmatic-way.tgz, quickstart.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991878#comment-12991878 ]
Alan Shaw commented on WICKET-3433:
-----------------------------------
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the faststart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid htm to the browser.
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025811#comment-13025811 ]
Martin Grigorov commented on WICKET-3433:
-----------------------------------------
Please test the fix here with getMarkupSettings().setStripComments(true);
This setting has some issues with IE conditional comments - see WICKET-3648.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: html5boilerplate.ui.wicket.parsefail-working.zip
I'm sending back your quickstart working
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008898#comment-13008898 ]
Juergen Donnerstag commented on WICKET-3433:
--------------------------------------------
Hi Pedro,
I'm not yet there, but I'd like to forward every tag (including comments) to markup filters, so that conditional comments can be fully handled by a markup filter.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: (was: WICKET-3433.patch)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: (was: WICKET-3433.patch)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WICKET-3433) Wicket parses HTML
inside IE conditional comments
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991878#comment-12991878 ]
Alan Shaw edited comment on WICKET-3433 at 2/8/11 11:13 AM:
------------------------------------------------------------
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid html to the browser.
=====
EDIT
This is incorrect. Wicket always parses HTML content in IE conditional comments. This is the problem.
was (Author: _alanshaw):
I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid html to the browser.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994254#comment-12994254 ]
Alan Shaw commented on WICKET-3433:
-----------------------------------
HTML5 boilerplate uses IE conditional comments so that you can still apply IE specific styles to browsers that don't have JavaScript enabled.
Wicket has no business in IE conditional comments. Wicket is not IE.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-3433:
---------------------------------------
Attachment: wicket-conditional-comments.patch
my working file with additional test cases
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: SimplePageExpectedResult_12a.html
Hi Juergen, the SimplePageTest#testRenderHomePage_12 is failing always, I'm attaching what I think that we should expect.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: (was: WICKET-3433-2.patch)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Shaw updated WICKET-3433:
------------------------------
Comment: was deleted
(was: I have tried this. It does not work.
Wicket DOESNT parse IE conditional comments normally (i.e. not when between doctype and opening html tag). So to Wicket, this looks like 1 closing html tag. The temporary solution (as I show in the quickstart) is to close 5 html tags (WITHOUT conditional comments):
</html></html></html></html></html>
Obviously this means that wicket is happy, but you're sending invalid html to the browser.
=====
EDIT
This is incorrect. Wicket always parses HTML content in IE conditional comments. This is the problem.)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994253#comment-12994253 ]
Martin Grigorov commented on WICKET-3433:
-----------------------------------------
I think we should not do anything for this issue.
The solution/workaround is to use the same checks for the closing (</html>) elements, as in Pedro's comment from 08/Feb/11 1:22 AM.
HTML5 Boilerplate uses IE comments because it is more easy for them, but most of the JS libraries use onDomReady to assign the classes - see http://davidwalsh.name/mootools-css for the MooTools and Dojo approaches.
Adding a new markup filter will just make things more complex than needed for no big gain.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-3433) Wicket parses HTML
inside IE conditional comments
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050405#comment-13050405 ]
Martin Grigorov edited comment on WICKET-3433 at 6/16/11 1:19 PM:
------------------------------------------------------------------
Attaching the fixed quickstart provided by Christian.
@Christian: its your turn again. Please create a wiki page, describe the use case and paste the relevant snippets :-)
was (Author: mgrigorov):
Attaching the fixed quickstart provider by Christian.
@Christian: its your turn again. Please create a wiki page, describe the use case and paste the relevant snippets :-)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, programmatic-way.tgz, quickstart.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Christian Lerch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lerch updated WICKET-3433:
------------------------------------
Attachment: quickstart.zip
Thanks Martin, that's gracious.
Please find attached a very simple quickstart, that should demonstrate that setting the class attribute on the html tag via TransparentWebMarkupContainer and AttributeAppender does not work, well, at least as I understand it. Please let me know what's wrong with it.
Thank you,
Chris
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, quickstart.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063387#comment-13063387 ]
Juergen Donnerstag commented on WICKET-3433:
--------------------------------------------
Microsoft removed support for Conditional Comments in IE10. See http://blogs.msdn.com/b/ie/archive/2010/04/14/same-markup-writing-cross-browser-code.aspx on MS proposed ways to solve cross browser issues.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, programmatic-way.tgz, quickstart.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Shaw updated WICKET-3433:
------------------------------
Summary: Wicket parses HTML inside IE conditional comments (was: Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag)
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433.patch
Hi Juergen, in the last commit you broke the HtmlHandler validation by moving it to postProcess (bug exposed by MarkupParserTest#testErrorOnMismatchTag in the patch). The problem is that postProcess is not invoked for all filters in the chain since its first filter - StyleAndScriptIdentifier - is not forwarding the call.
I understand your idea of moving the conditional comments handle code to a filter in the chain, I think it is OK and it is why I moved it to there in my second patch I guess.
In your last commit you also made a relatively big change in the parser by not considering the XmlTag as a MarkupElement. I also agree with the change, and merged it into my patch. But I ask you to hold on further changes in the parser until we close this ticket, because it's getting hard to follow you in the changes.
The Wicket parser is an hostile land for newcomers, I already saw a single innocent line invoking a method in the wrong sequence break more than 500 test cases.
The new attached patch fix this issue, the WICKET-3500, and the on described before.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433.patch
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994264#comment-12994264 ]
Pedro Santos commented on WICKET-3433:
--------------------------------------
The big problem is that open some tag N times inside conditional comments an close it once gives us valid markup, I tested on w3c checker, and every browser understands it, I tested on Chrome, FireFox, Opera and Safari.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991893#comment-12991893 ]
Alan Shaw commented on WICKET-3433:
-----------------------------------
Yes, it would, if you could get it to the browser, but wicket will throw an error and complain of mismatched tags. 5 opening html and 1 closing.
I can submit another quickstart to demonstrate if that isn't clear.
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433-2.patch
Hi Juergen, I'm attaching the patch with a new filter to skip tags inside conditional comments as you suggested. Below some explains about changed classes in the patch:
- AbstractMarkupParser and WicketRemoveTagHandler: changed to support early test of tags on ConditionalCommentFilter
- TagStack: html tags open close balance control moved out from HtmlHandler to be used by ConditionalCommentFilter also
- ConditionalComment: class created to enable parse filters to control this MarkupElement
- XmlPullParser: changed to support the new markup element type - ConditionalComment
- ConditionalCommentFilter: new filter in the chain to skip mismatch tags inside conditional comments
- RootMarkupFilter: changed to return the new comment type to chained filters
- WicketTagIdentifier: simple change to avoid class cast exceptions
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433-2.patch, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Shaw updated WICKET-3433:
------------------------------
Comment: was deleted
(was: Yes, it would, if you could get it to the browser, but wicket will throw an error and complain of mismatched tags. 5 opening html and 1 closing.
I can submit another quickstart to demonstrate if that isn't clear.)
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033608#comment-13033608 ]
Igor Vaynberg commented on WICKET-3433:
---------------------------------------
where are we on this?
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WICKET-3433) Wicket parses HTML
inside IE conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996854#comment-12996854 ]
Pedro Santos edited comment on WICKET-3433 at 2/19/11 8:49 PM:
---------------------------------------------------------------
Hi Juergen thank for the review. The idea of skip repeated markup inside the conditional comments has those drawbacks you pointed, we would have to skip only repeated not closed or not opend tags inside different conditional comments to solve it. I think it can be done nicely, let me come back with another path.
I didn't fixed the MarkupParserTest by closing the link tag at MarkupParserTest_9.html because it wasn't failing, I just reverted it here to maintain it testing the tolerance of non close tags, thanks for noticed and test cases.
was (Author: pedrosans):
Hi Juergen thank for the review. The idea of skip repeated markup inside the conditional comments has those drawbacks you pointed, we would have to skip only repeated not closed tags inside different conditional comments to solve it. I think it can be done nicely, let me come back with another path.
I didn't fixed the MarkupParserTest by closing the link tag at MarkupParserTest_9.html because it wasn't failing, I just reverted it here to maintain it testing the tolerance of non close tags, thanks for noticed and test cases.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Alan Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991938#comment-12991938 ]
Alan Shaw commented on WICKET-3433:
-----------------------------------
You are correct, apologies. The problem is slightly different to what I thought the problem was.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991891#comment-12991891 ]
Pedro Santos commented on WICKET-3433:
--------------------------------------
Wicket chunks the conditional comment and parse only the markup inside it. Closing the html the as many times it was opened (as you suggested ), and wrapping then inside the correspondent conditional comments (as I'm suggesting) generate valid html to browser, I just tested in http://validator.w3.org/check
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments when they appear between the doctype declaration and
the tag
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991763#comment-12991763 ]
Pedro Santos commented on WICKET-3433:
--------------------------------------
Close the html tag as below for now (as you suggested in the quickstart), IMO MarkupParser needs to allow your usecase.
<!--[if lt IE 7 ]> </html> <![endif]-->
<!--[if IE 7 ]> </html> <![endif]-->
<!--[if IE 8 ]> </html> <![endif]-->
<!--[if IE 9 ]> </html> <![endif]-->
<!--[if (gt IE 9)|!(IE)]><!--> </html> <!--<![endif]-->
> Wicket parses HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995192#comment-12995192 ]
Igor Vaynberg commented on WICKET-3433:
---------------------------------------
thanks for the patch Pedro, lets see if Juergen agrees.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996854#comment-12996854 ]
Pedro Santos commented on WICKET-3433:
--------------------------------------
Hi Juergen thank for the review. The idea of skip repeated markup inside the conditional comments has those drawbacks you pointed, we would have to skip only repeated not closed tags inside different conditional comments to solve it. I think it can be done nicely, let me come back with another path.
I didn't fixed the MarkupParserTest by closing the link tag at MarkupParserTest_9.html because it wasn't failing, I just reverted it here to maintain it testing the tolerance of non close tags, thanks for noticed and test cases.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3433) Wicket parses HTML inside IE
conditional comments
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433.patch
same patch for the current trunk
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch, html5boilerplate.ui.wicket.parsefail-working.zip, html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse HTML inside IE conditional comments when they appear between the doctype declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira