You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/01 14:45:53 UTC
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
> On Nov. 30, 2015, 6:47 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 393-394
> > <https://reviews.apache.org/r/40746/diff/1/?file=1147458#file1147458line393>
> >
> > `RemoveQuota` appears idempotent, so what is the problem with trying to remove a quota that is currently being removed?
> >
> > Is it the fact that you check this?
> > ```
> > // Check that we are removing an existing quota.
> > if (!master->quotas.contains(role)) { ... }
> > ```
`RemoveQuota` is idempotent, right, but `HierarchicalAllocatorProcess::removeQuota()` is not. I think we can change the whole function to be idempotent, but is this really necessary?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108359
-----------------------------------------------------------
On Nov. 26, 2015, 12:28 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 12:28 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>