You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/18 01:19:34 UTC
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 6:19 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
Summary (updated)
-----------------
Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.
Repository: mesos
Description (updated)
-------
By adding a `:` to the default executor ID used by the tests, this
thoroughly exercises MESOS-9109.
Diffs (updated)
-----
src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
Diff: https://reviews.apache.org/r/68301/diff/3/
Changes: https://reviews.apache.org/r/68301/diff/2-3/
Testing
-------
This should have _almost_ all the tests pass, except for:
```
[ FAILED ] 9 tests, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
```
Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review207835
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68420, 68422, 68375, 68297, 68374, 68301]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 23, 2018, 6:26 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/4/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review213686
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68297', '68374', '68301']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2937/mesos-review-68301
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2937/mesos-review-68301/logs/mesos-tests.log):
```
W0313 20:25:34.569185 9964 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=14064 to peer '192.10.1.4:63426': IO failed with error code: The specified network name is no longer available.
I0313 20:25:34.585218 8552 containerizer.cpp:3117] Container 98dfa831-a280-4247-a5ac-63fa58cef8db has exited
I0313 20:25:34.617194 8552 master.cpp:1135] Master terminating
I0313 20:25:34.618181 2412 hierarc[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (692 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (711 ms total)
[----------] Global test environment tear-down
[==========] 1115 tests from 106 test cases ran. (660523 ms total)
[ PASSED ] 1104 tests.
[ FAILED ] 11 tests, listed below:
[ FAILED ] GarbageCollectorIntegrationTest.LongLivedDefaultExecutor
[ FAILED ] GarbageCollectorIntegrationTest.LongLivedDefaultExecutorRestart
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
11 FAILED TESTS
YOU HAVE 232 DISABLED TESTS
hical.cpp:678] Removed agent f1807198-588f-42ab-ba0d-83bfd0c0ff6c-S0
I0313 20:25:34.881379 9964 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 23, 2018, 6:26 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/4/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review207828
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68420', '68422', '68375', '68297', '68374', '68301']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2226/mesos-review-68301
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2226/mesos-review-68301/logs/mesos-tests.log):
```
I0823 19:26:55.783251 4000 hierarchical.cpp:359] Removed framework 777b3463-e1ca-46fd-875f-60df9c87ce29-0000
I0823 19:26:55.783251 4000 hierarchical.cpp:795] Agent 777b3463-e1ca-46fd-875f-60df9c87ce29-S0 deactivated
I0823 19:26:55.783251 6384 containerizer.cpp:2427] Destr[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (583 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (606 ms total)
[----------] Global test environment tear-down
[==========] 1030 tests from 101 test cases ran. (563361 ms total)
[ PASSED ] 1021 tests.
[ FAILED ] 9 tests, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
9 FAILED TESTS
YOU HAVE 222 DISABLED TESTS
oying container f542895b-1865-4d14-9231-bf40808ea956 in RUNNING state
I0823 19:26:55.784253 6384 containerizer.cpp:3041] Transitioning the state of container f542895b-1865-4d14-9231-bf40808ea956 from RUNNING to DESTROYING
I0823 19:26:55.784253 6384 launcher.cpp:166] Asked to destroy container f542895b-1865-4d14-9231-bf40808ea956
I0823 19:26:55.794247 11032 containerizer.cpp:2880] Container f542895b-1865-4d14-9231-bf40808ea956 has exited
I0823 19:26:55.822252 8948 master.cpp:1093] Master terminating
I0823 19:26:55.823266 12724 hierarchical.cpp:637] Removed agent 777b3463-e1ca-46fd-875f-60df9c87ce29-S0
I0823 19:26:56.061292 8892 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 23, 2018, 11:26 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 11:26 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/4/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review213348
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68420, 68422, 68375, 68297, 68374, 68301]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 23, 2018, 11:26 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 11:26 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/4/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 11:26 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
By adding a `:` to the default executor ID used by the tests, this
thoroughly exercises MESOS-9109.
Diffs (updated)
-----
src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
src/tests/master_tests.cpp 1db8ed7d81acbcd8bad4b7ca77c501d1d99cc135
src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
Diff: https://reviews.apache.org/r/68301/diff/4/
Changes: https://reviews.apache.org/r/68301/diff/3-4/
Testing
-------
This should have _almost_ all the tests pass, except for:
```
[ FAILED ] 9 tests, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
```
Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review207583
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68420, 68422, 68375, 68297, 68374, 68301]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 18, 2018, 1:19 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/3/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Aug. 17, 2018, 7:22 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['68420', '68422', '68375', '68297', '68374', '68301']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2192/mesos-review-68301
> >
> > Relevant logs:
> >
> > - [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2192/mesos-review-68301/logs/mesos-tests.log):
> >
> > ```
> > I0818 02:22:05.121134 28916 hier[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (693 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (713 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1030 tests from 101 test cases ran. (598964 ms total)
> > [ PASSED ] 1020 tests.
> > [ FAILED ] 10 tests, listed below:
> > [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> > [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> > [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> > [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> > [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> > [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> > [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "docker,mesos"
> > [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> > [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> > [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> >
> > 10 FAILED TESTS
> > YOU HAVE 222 DISABLED TESTS
> >
> > archical.cpp:795] Agent 2ca394f1-f5a9-4188-add6-1beb8e603e46-S0 deactivated
> > I0818 02:22:05.123139 28916 containerizer.cpp:2416] Destroying container 1cf96023-8016-42bf-9209-66b4f8dd101e in RUNNING state
> > I0818 02:22:05.123139 28916 containerizer.cpp:3030] Transitioning the state of container 1cf96023-8016-42bf-9209-66b4f8dd101e from RUNNING to DESTROYING
> > I0818 02:22:05.124130 28916 launcher.cpp:166] Asked to destroy container 1cf96023-8016-42bf-9209-66b4f8dd101e
> > I0818 02:22:05.182164 28280 containerizer.cpp:2869] Container 1cf96023-8016-42bf-9209-66b4f8dd101e has exited
> > I0818 02:22:05.212131 28068 master.cpp:1093] Master terminating
> > I0818 02:22:05.214131 4480 hierarchical.cpp:637] Removed agent 2ca394f1-f5a9-4188-add6-1beb8e603e46-S0
> > I0818 02:22:05.592200 5000 process.cpp:926] Stopped the socket accept loop
> > ```
These are expected due to long path issues on the host. We could (a) change `TMP` in the tests (not very nice) or (b) change `TMP` on the build machines themselves, which would work.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review207579
-----------------------------------------------------------
On Aug. 17, 2018, 6:19 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 6:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/3/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use
`default:id`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/#review207579
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68420', '68422', '68375', '68297', '68374', '68301']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2192/mesos-review-68301
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2192/mesos-review-68301/logs/mesos-tests.log):
```
I0818 02:22:05.121134 28916 hier[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (693 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (713 ms total)
[----------] Global test environment tear-down
[==========] 1030 tests from 101 test cases ran. (598964 ms total)
[ PASSED ] 1020 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
10 FAILED TESTS
YOU HAVE 222 DISABLED TESTS
archical.cpp:795] Agent 2ca394f1-f5a9-4188-add6-1beb8e603e46-S0 deactivated
I0818 02:22:05.123139 28916 containerizer.cpp:2416] Destroying container 1cf96023-8016-42bf-9209-66b4f8dd101e in RUNNING state
I0818 02:22:05.123139 28916 containerizer.cpp:3030] Transitioning the state of container 1cf96023-8016-42bf-9209-66b4f8dd101e from RUNNING to DESTROYING
I0818 02:22:05.124130 28916 launcher.cpp:166] Asked to destroy container 1cf96023-8016-42bf-9209-66b4f8dd101e
I0818 02:22:05.182164 28280 containerizer.cpp:2869] Container 1cf96023-8016-42bf-9209-66b4f8dd101e has exited
I0818 02:22:05.212131 28068 master.cpp:1093] Master terminating
I0818 02:22:05.214131 4480 hierarchical.cpp:637] Removed agent 2ca394f1-f5a9-4188-add6-1beb8e603e46-S0
I0818 02:22:05.592200 5000 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 18, 2018, 1:19 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68301/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding a `:` to the default executor ID used by the tests, this
> thoroughly exercises MESOS-9109.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
> src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
> src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274
>
>
> Diff: https://reviews.apache.org/r/68301/diff/3/
>
>
> Testing
> -------
>
> This should have _almost_ all the tests pass, except for:
>
> ```
> [ FAILED ] 9 tests, listed below:
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
> [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
> [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
> ```
>
> Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>