[GitHub] [spark] amaliujia commented on a diff in pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38659:
URL: https://github.com/apache/spark/pull/38659#discussion_r1024749559


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -213,7 +213,7 @@ message Deduplicate {
 
 message LocalRelation {
   repeated Expression.QualifiedAttribute attributes = 1;

Review Comment:
   For short term it should work. We probably only need `name` and `type` to ask server side construct such attributes for the local relation.
   
   For longer term I am not sure. Depending on if there are other extra information that LocalRelation needs from such attributes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org