Re: [PR] fix(login): oauth and ldap login ignoring superset_app_root [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #34657:
URL: https://github.com/apache/superset/pull/34657#issuecomment-5012327845

   Hey @lguichard78, this is still showing as conflicting with `master`, needs a rebase before we can merge. I'll see if I can help there.
   
   Also, `sharded-jest-tests (8)` is genuinely red here, not flaky: `Login.test.tsx`'s SAML test throws `TypeError: applicationRoot is not a function` because `buildProviderLoginUrl` now calls `ensureAppRoot`, and the test's `getBootstrapData` mock doesn't provide `applicationRoot`. Needs a fix to the test mock alongside the rebase.
   
   The `ensureAppRoot` approach itself still seems right for #34552. Once it's rebased and that test's passing we can take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org