[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #141: [FLINK-26894] Support custom validator implementations

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #141:
URL: https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r844005053


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/FlinkResourceValidator.java:
##########
@@ -17,18 +17,19 @@
 
 package org.apache.flink.kubernetes.operator.validation;
 
+import org.apache.flink.core.plugin.Plugin;
 import org.apache.flink.kubernetes.operator.crd.FlinkDeployment;
 import org.apache.flink.kubernetes.operator.crd.FlinkSessionJob;
 
 import java.util.Optional;
 
 /** Validator for different resources. */
-public interface FlinkResourceValidator {
+public interface FlinkResourceValidator extends Plugin {

Review Comment:
   @wangyang0918, I have added the call of the `configure()` in `ValidatorUtils`. IMO, the advantage isn't too necessary to  introduce the `FlinkResourceValidatorFactory`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org