You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/09 04:09:14 UTC

[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector

wuchong commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-705956351


   Hi @pyscala , thanks for the updating. 
   
   However, the new added `discoverOptionalFactory` method still no generic method for all kinds of fatories. What I mean was that you can just call `discoverFactory` and catch the exception in `discoverOptionalFactory`. And wrap the pretty exception message in `getDynamicTableFactory`. In `getDynamicTableFactory` you can use `discoverOptionalFactory` to discover for source and sink both and throw better exception if it is source-only but discovering sink or vise-versa. 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org