You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/03 15:14:53 UTC

[GitHub] [incubator-nuttx-apps] v01d edited a comment on pull request #647: nshlib: Disable mb, mh, and mw by default

v01d edited a comment on pull request #647:
URL: https://github.com/apache/incubator-nuttx-apps/pull/647#issuecomment-812876361


   ~~@xiaoxiang781216 as @btashton mentioned, the Kconfig change is backwards to the intent of the PR. I don't think this should have been merged.~~ Ah, I was confused by @btashton command the fact that this is enabling the disable of the commands. I'm not sure if the CI errors were up to date though.
   
   Also, I see quite a few issues such as:
   ```
   < CONFIG_NSH_DISABLE_MB=y
   < CONFIG_NSH_DISABLE_MH=y
   63d60
   < CONFIG_NSH_DISABLE_MW=y
   ```
   in CI.
   
   Let's try not to make a habit of skipping CI (it is now quite faster and less wasteful when pushing again) as we will loose unexpected errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org