[jira] [Commented] (CALCITE-4234) RelBuilder.AggCallImpl#aggregateCall() throws NullPointerException

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208386#comment-17208386 ] 

Vladimir Sitnikov commented on CALCITE-4234:
--------------------------------------------

{quote}  I don't think the null type is a problem.{quote}
Well, there's {{requireNonNull(type)}}: https://github.com/apache/calcite/blob/64a0ca71038da14f0f883f169aa95df00d909e06/core/src/main/java/org/apache/calcite/rel/core/AggregateCall.java#L96 , so I guess passing null to type argument would fail with NPE as well.



> RelBuilder.AggCallImpl#aggregateCall() throws NullPointerException
> ------------------------------------------------------------------
>
>                 Key: CALCITE-4234
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4234
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> CALCITE-4220 introduced the following method:
> {code:java}
>     @Override public AggregateCall aggregateCall() {
>       return AggregateCall.create(aggFunction, distinct, approximate,
>           ignoreNulls, ImmutableList.of(), -1, /* collation: */ null, /* type: */ null, alias);
>     }
> {code}
> In practice {{AggregateCall}} constructor has {{null}} checks, so {{aggregateCall}} would always throw NPE:
> {code:java}
>     this.type = Objects.requireNonNull(type);
>     this.collation = Objects.requireNonNull(collation);
> {code}
> [~julianhyde], would you please check if that behavior is expected?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)