[GitHub] [kafka] jeffkbkim commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

[GitBox <gi...@apache.org>]

jeffkbkim commented on a change in pull request #8935:
URL: https://github.com/apache/kafka/pull/8935#discussion_r454035533



##########
File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala
##########
@@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,
     }
   }
 
+  private def pollFromEventQueue(): QueuedEvent = {
+    val count = eventQueueTimeHist.count()

Review comment:
       @junrao I'm not sure I follow. If there are no more events in the queue (`count != 0`), we'd like the histogram to reset after a specified timeout. `count` will always be a non-zero value until we reset the histogram.
   
   If we block on queue.take() forever even when `count != 0`, wouldn't that behave the same way as before? In which case do you suggest resetting?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org