You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Dan Harvey <da...@gmail.com> on 2015/05/01 20:22:08 UTC
Re: Review Request 33297: [SAMZA-654] Added
ElasticsearchSystemProducer and
Factory to output messages into Elasticseach indexes.
> On April 23, 2015, 11:51 p.m., Navina Ramesh wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java, line 37
> > <https://reviews.apache.org/r/33297/diff/4/?file=940529#file940529line37>
> >
> > This might be a lack of understanding about elasticsearch from my side. But why are you making these assumptions here?
> >
> > Can you handle the exceptions here?
Ah sorry, this was a note to myself to come back and think over this. The elastichsearch Java client can take json as either a byte[], Map, or object that it tries to map to a json object. Right now for my use case I only need byte[]/Map so I've now implemented checks for that. As future work we could add support for using Samza configurable serialisers to turn into byte[] and possible pass more though to the client. But I think what I've now done is good for basic use.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33297/#review81430
-----------------------------------------------------------
On April 23, 2015, 6:18 p.m., Dan Harvey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33297/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 6:18 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.
>
>
> Diffs
> -----
>
> build.gradle 97de3a28f6379e3862eec845da87587b1d4f742e
> gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e
> samza-elasticsearch/src/main/java/org/apache/samza/config/ElasticsearchConfig.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemAdmin.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/ClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/NodeClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/client/TransportClientFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java PRE-CREATION
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/IndexRequestFactory.java PRE-CREATION
> settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb
>
> Diff: https://reviews.apache.org/r/33297/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Harvey
>
>