You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by pr...@apache.org on 2025/02/19 08:26:17 UTC

(impala) branch branch-4.5.0 updated (71b7d2af3 -> 7dd93d461)

This is an automated email from the ASF dual-hosted git repository.

prozsa pushed a change to branch branch-4.5.0
in repository https://gitbox.apache.org/repos/asf/impala.git


 discard 71b7d2af3 Release 4.5.0
     new 8f6eee94f IMPALA-13761: Fix test_coord_only_pool_exec_groups
     new 7dd93d461 Release 4.5.0

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (71b7d2af3)
            \
             N -- N -- N   refs/heads/branch-4.5.0 (7dd93d461)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/save-version.sh                               |  2 +-
 tests/custom_cluster/test_admission_controller.py | 26 +++++++++++++++--------
 2 files changed, 18 insertions(+), 10 deletions(-)


(impala) 01/02: IMPALA-13761: Fix test_coord_only_pool_exec_groups

Posted by pr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

prozsa pushed a commit to branch branch-4.5.0
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 8f6eee94f3b067161fe724687cea27ce5a8ab04d
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Sat Feb 15 17:54:10 2025 -0800

    IMPALA-13761: Fix test_coord_only_pool_exec_groups
    
    IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
    TestAdmissionControllerWithACService due to unaccounted AdmissionD as
    the extra statestore subscriber. This patch fix the issue by using
    expected_subscribers and expected_num_impalads argument for
    CustomClusterTestSuite._start_impala_cluster() and relies on wait
    mechanism inside it.
    
    This patch also does some adjustments:
    1. Tweak __run_assert_systables_query to not use
       execute_query_using_vector from IMPALA-13694.
    2. Remove default_impala_client() call, first added by IMPALA-13668, and
       use self.client instead.
    3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
    These make it possible to backport IMPALA-13201 and IMPALA-13761
    together to older release/maintenance branch.
    
    Testing:
    Run the test with this command:
    impala-py.test --exploration=exhaustive \
      -k test_coord_only_pool custom_cluster/test_admission_controller.py
    
    Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
    Reviewed-on: http://gerrit.cloudera.org:8080/22486
    Reviewed-by: Peter Rozsa <pr...@cloudera.com>
    Reviewed-by: Jason Fehr <jf...@cloudera.com>
    Tested-by: Jason Fehr <jf...@cloudera.com>
---
 tests/custom_cluster/test_admission_controller.py | 26 +++++++++++++++--------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py
index 0b07749f3..3fe9dd341 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -1833,8 +1833,9 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
         'llama-site-onlycoords.xml'."""
 
     vector.set_exec_option('request_pool', 'onlycoords')
-    result = self.execute_query_using_vector(query, vector)
-    assert result.success
+    with self.create_impala_client(protocol=vector.get_value('protocol')) as client:
+      result = self.execute_query_using_client(client, query, vector)
+      assert result.success
 
     self.__assert_systables_query(result.runtime_profile, expected_coords,
       expected_frag_counts)
@@ -1860,7 +1861,7 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
     # without running any on the executors.
     self.__run_assert_systables_query(
         vector=vector,
-        expected_frag_counts=[4, 2, 2,],
+        expected_frag_counts=[4, 2, 2],
         query="select a.test_name, b.db_user from functional.jointbl a inner join "
               "sys.impala_query_live b on a.test_name = b.db_name"),
 
@@ -1915,13 +1916,12 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
     coord_to_term.kill()
 
     vector.set_exec_option('request_pool', 'onlycoords')
-    client = self.default_impala_client(vector.get_value('protocol'))
 
     done_waiting = False
     iterations = 0
     while not done_waiting and iterations < 20:
       try:
-        result = self.execute_query_using_client(client, ACTIVE_SQL, vector)
+        result = self.execute_query_using_client(self.client, ACTIVE_SQL, vector)
         assert result.success
         done_waiting = True
       except Exception as e:
@@ -1987,25 +1987,33 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite):
 
     # Assert queries can be run when no executors are started.
     self.__run_assert_systables_query(vector)
+    # If not using admissiond, there should be 2 statestore subscribers now
+    # (1 impalad and 1 catalogd). Otherwise, admissiond is the 3rd statestore subscriber.
+    expected_subscribers = 3 if self.get_ac_log_name() == 'admissiond' else 2
+    expected_num_impalads = 1
 
     # Add a single executor for the small executor group set.
+    expected_subscribers += 1
+    expected_num_impalads += 1
     self._start_impala_cluster(
         options=[
             "--impalad_args=--executor_groups=root.group-set-small-group-000:1"],
         add_executors=True,
         cluster_size=1,
-        wait_for_backends=False)
-    self.cluster.statestored.service.wait_for_live_subscribers(3, timeout=30)
+        expected_subscribers=expected_subscribers,
+        expected_num_impalads=expected_num_impalads)
     self.__run_assert_systables_query(vector)
 
     # Add two executors for the large executor group set.
+    expected_subscribers += 2
+    expected_num_impalads += 2
     self._start_impala_cluster(
         options=[
             "--impalad_args=--executor_groups=root.group-set-small-group-000:2"],
         add_executors=True,
         cluster_size=2,
-        wait_for_backends=False)
-    self.cluster.statestored.service.wait_for_live_subscribers(5, timeout=30)
+        expected_subscribers=expected_subscribers,
+        expected_num_impalads=expected_num_impalads)
     self.__run_assert_systables_query(vector)
 
 


(impala) 02/02: Release 4.5.0

Posted by pr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

prozsa pushed a commit to branch branch-4.5.0
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 7dd93d46183dd7a18e1f15511ea2c56895792654
Author: Peter Rozsa <pr...@cloudera.com>
AuthorDate: Wed Jan 29 11:06:35 2025 +0100

    Release 4.5.0
    
    Change-Id: Idb2fe419f645415cb1768095a0c537de75add13d
---
 bin/impala-config.sh                 | 2 +-
 bin/save-version.sh                  | 2 +-
 fe/pom.xml                           | 2 +-
 java/TableFlattener/pom.xml          | 2 +-
 java/calcite-planner/pom.xml         | 6 +++---
 java/datagenerator/pom.xml           | 2 +-
 java/executor-deps/pom.xml           | 2 +-
 java/ext-data-source/api/pom.xml     | 2 +-
 java/ext-data-source/jdbc/pom.xml    | 2 +-
 java/ext-data-source/pom.xml         | 2 +-
 java/ext-data-source/sample/pom.xml  | 2 +-
 java/ext-data-source/test/pom.xml    | 2 +-
 java/external-frontend/pom.xml       | 4 ++--
 java/pom.xml                         | 2 +-
 java/puffin-data-generator/pom.xml   | 2 +-
 java/query-event-hook-api/pom.xml    | 2 +-
 java/shaded-deps/hive-exec/pom.xml   | 2 +-
 java/shaded-deps/s3a-aws-sdk/pom.xml | 2 +-
 java/test-corrupt-hive-udfs/pom.xml  | 2 +-
 java/test-hive-udfs/pom.xml          | 2 +-
 java/yarn-extras/pom.xml             | 2 +-
 21 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index d7d0fdf36..904870533 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -70,7 +70,7 @@ fi
 # WARNING: If changing this value, also run these commands:
 # cd ${IMPALA_HOME}/java
 # mvn versions:set -DnewVersion=YOUR_NEW_VERSION
-export IMPALA_VERSION=4.5.0-SNAPSHOT
+export IMPALA_VERSION=4.5.0-RELEASE
 
 # Whether to build the backend on Avro C++ library or C.
 # This is added temporarily to help transitioning from Avro C to C++ library.
diff --git a/bin/save-version.sh b/bin/save-version.sh
index 85e5f899e..735df29e8 100755
--- a/bin/save-version.sh
+++ b/bin/save-version.sh
@@ -22,7 +22,7 @@
 # "-INTERNAL" appended. Parts of the code will look for this to distinguish
 # between released and internal versions.
 VERSION=${IMPALA_VERSION}
-GIT_HASH=$(git rev-parse HEAD 2> /dev/null)
+GIT_HASH=8f6eee94f3b067161fe724687cea27ce5a8ab04d
 if [ -z $GIT_HASH ]
 then
   GIT_HASH="Could not obtain git hash"
diff --git a/fe/pom.xml b/fe/pom.xml
index 450f27280..05f5b0a58 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
     <relativePath>../java/pom.xml</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
diff --git a/java/TableFlattener/pom.xml b/java/TableFlattener/pom.xml
index b7d0d28d0..7c5abaaa5 100644
--- a/java/TableFlattener/pom.xml
+++ b/java/TableFlattener/pom.xml
@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <artifactId>nested-table-flattener</artifactId>
diff --git a/java/calcite-planner/pom.xml b/java/calcite-planner/pom.xml
index e00925046..a97d53b67 100644
--- a/java/calcite-planner/pom.xml
+++ b/java/calcite-planner/pom.xml
@@ -22,12 +22,12 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
   <artifactId>calcite-planner</artifactId>
-  <version>4.5.0-SNAPSHOT</version>
+  <version>4.5.0-RELEASE</version>
   <packaging>jar</packaging>
 
   <name>calcite-planner</name>
@@ -36,7 +36,7 @@ under the License.
     <dependency>
       <groupId>org.apache.impala</groupId>
       <artifactId>impala-frontend</artifactId>
-      <version>4.5.0-SNAPSHOT</version>
+      <version>4.5.0-RELEASE</version>
     </dependency>
     <dependency>
       <groupId>org.apache.calcite</groupId>
diff --git a/java/datagenerator/pom.xml b/java/datagenerator/pom.xml
index b6e8f3b3f..d34b16b0f 100644
--- a/java/datagenerator/pom.xml
+++ b/java/datagenerator/pom.xml
@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/executor-deps/pom.xml b/java/executor-deps/pom.xml
index 62a31d54d..6c6c3c958 100644
--- a/java/executor-deps/pom.xml
+++ b/java/executor-deps/pom.xml
@@ -34,7 +34,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <groupId>org.apache.impala</groupId>
diff --git a/java/ext-data-source/api/pom.xml b/java/ext-data-source/api/pom.xml
index 32c4b8a4c..8ec23cdbd 100644
--- a/java/ext-data-source/api/pom.xml
+++ b/java/ext-data-source/api/pom.xml
@@ -23,7 +23,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-data-source</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <artifactId>impala-data-source-api</artifactId>
   <name>Apache Impala External Data Source API</name>
diff --git a/java/ext-data-source/jdbc/pom.xml b/java/ext-data-source/jdbc/pom.xml
index 6b39daf96..f9658cba0 100644
--- a/java/ext-data-source/jdbc/pom.xml
+++ b/java/ext-data-source/jdbc/pom.xml
@@ -23,7 +23,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-data-source</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <artifactId>impala-data-source-jdbc</artifactId>
   <name>Apache Impala External Data Source JDBC Library</name>
diff --git a/java/ext-data-source/pom.xml b/java/ext-data-source/pom.xml
index 87e25f207..16797631a 100644
--- a/java/ext-data-source/pom.xml
+++ b/java/ext-data-source/pom.xml
@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <artifactId>impala-data-source</artifactId>
diff --git a/java/ext-data-source/sample/pom.xml b/java/ext-data-source/sample/pom.xml
index 6f3860a4f..6148e1a45 100644
--- a/java/ext-data-source/sample/pom.xml
+++ b/java/ext-data-source/sample/pom.xml
@@ -23,7 +23,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-data-source</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <artifactId>impala-data-source-sample</artifactId>
   <name>Apache Impala External Data Source Sample</name>
diff --git a/java/ext-data-source/test/pom.xml b/java/ext-data-source/test/pom.xml
index a25728e03..292fc447f 100644
--- a/java/ext-data-source/test/pom.xml
+++ b/java/ext-data-source/test/pom.xml
@@ -23,7 +23,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-data-source</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <artifactId>impala-data-source-test</artifactId>
   <name>Apache Impala External Data Source Test Library</name>
diff --git a/java/external-frontend/pom.xml b/java/external-frontend/pom.xml
index 2b46b8a8c..416eb26d3 100644
--- a/java/external-frontend/pom.xml
+++ b/java/external-frontend/pom.xml
@@ -22,7 +22,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
@@ -36,7 +36,7 @@ under the License.
     <dependency>
       <groupId>org.apache.impala</groupId>
       <artifactId>impala-frontend</artifactId>
-      <version>4.5.0-SNAPSHOT</version>
+      <version>4.5.0-RELEASE</version>
     </dependency>
   </dependencies>
 
diff --git a/java/pom.xml b/java/pom.xml
index ae5752532..89a126a22 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -21,7 +21,7 @@ under the License.
   <modelVersion>4.0.0</modelVersion>
   <groupId>org.apache.impala</groupId>
   <artifactId>impala-parent</artifactId>
-  <version>4.5.0-SNAPSHOT</version>
+  <version>4.5.0-RELEASE</version>
   <packaging>pom</packaging>
   <name>Apache Impala Parent POM</name>
 
diff --git a/java/puffin-data-generator/pom.xml b/java/puffin-data-generator/pom.xml
index 9688b1f6f..5d4780768 100644
--- a/java/puffin-data-generator/pom.xml
+++ b/java/puffin-data-generator/pom.xml
@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/query-event-hook-api/pom.xml b/java/query-event-hook-api/pom.xml
index ce74b4391..510f44058 100644
--- a/java/query-event-hook-api/pom.xml
+++ b/java/query-event-hook-api/pom.xml
@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <artifactId>query-event-hook-api</artifactId>
diff --git a/java/shaded-deps/hive-exec/pom.xml b/java/shaded-deps/hive-exec/pom.xml
index 18be87df6..d8c8e2547 100644
--- a/java/shaded-deps/hive-exec/pom.xml
+++ b/java/shaded-deps/hive-exec/pom.xml
@@ -27,7 +27,7 @@ the same dependencies
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
     <relativePath>../../pom.xml</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
diff --git a/java/shaded-deps/s3a-aws-sdk/pom.xml b/java/shaded-deps/s3a-aws-sdk/pom.xml
index 26e6995fa..511e86bfe 100644
--- a/java/shaded-deps/s3a-aws-sdk/pom.xml
+++ b/java/shaded-deps/s3a-aws-sdk/pom.xml
@@ -25,7 +25,7 @@ though some of them might not be necessary. The exclusions are sorted alphabetic
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
     <relativePath>../../pom.xml</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
diff --git a/java/test-corrupt-hive-udfs/pom.xml b/java/test-corrupt-hive-udfs/pom.xml
index d78274ab4..cf6b1c3e3 100644
--- a/java/test-corrupt-hive-udfs/pom.xml
+++ b/java/test-corrupt-hive-udfs/pom.xml
@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/test-hive-udfs/pom.xml b/java/test-hive-udfs/pom.xml
index 5120c46d7..24ea139e3 100644
--- a/java/test-hive-udfs/pom.xml
+++ b/java/test-hive-udfs/pom.xml
@@ -22,7 +22,7 @@ under the License.
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/java/yarn-extras/pom.xml b/java/yarn-extras/pom.xml
index 2dfb3f051..740b1eaf8 100644
--- a/java/yarn-extras/pom.xml
+++ b/java/yarn-extras/pom.xml
@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.impala</groupId>
     <artifactId>impala-parent</artifactId>
-    <version>4.5.0-SNAPSHOT</version>
+    <version>4.5.0-RELEASE</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <artifactId>yarn-extras</artifactId>