You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/11 09:00:50 UTC

[GitHub] [superset] nandanrao opened a new pull request #16191: fixed envFromSecrets spacing in helm chart

nandanrao opened a new pull request #16191:
URL: https://github.com/apache/superset/pull/16191


   Previous, the spacing in the in the envFromSecrets caused a problem in yaml > json conversion and errored when attempting to use: 
   
   ```shell
   Error: UPGRADE FAILED: YAML parse error on superset/templates/deployment-worker.yaml: error converting YAML to JSON: yaml: line 71: did not find expected key
   ```
   
   Fixing the spacing seems to have solved the issue. 
   
   Cheers! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nandanrao closed pull request #16191: fix: envFromSecrets spacing in helm chart

Posted by GitBox <gi...@apache.org>.
nandanrao closed pull request #16191:
URL: https://github.com/apache/superset/pull/16191


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nandanrao closed pull request #16191: fixed envFromSecrets spacing in helm chart

Posted by GitBox <gi...@apache.org>.
nandanrao closed pull request #16191:
URL: https://github.com/apache/superset/pull/16191


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on pull request #16191: fix: envFromSecrets spacing in helm chart

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16191:
URL: https://github.com/apache/superset/pull/16191#issuecomment-897307369


   Hi, i have to change your PR title to start running test.. can you provide more details and fill out the pr template? thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nandanrao commented on pull request #16191: fix: envFromSecrets spacing in helm chart

Posted by GitBox <gi...@apache.org>.
nandanrao commented on pull request #16191:
URL: https://github.com/apache/superset/pull/16191#issuecomment-897873983


   Hi @junlincc, really sorry but actually this was fixed in https://github.com/apache/superset/commit/08bda27a433b558b9fee588185d2ee576504bf3b#diff-c5c7a406f329bb56e94d0390abb6243a7dce24c20309fc882d747e280905724d. 
   
   I was working off of a previous tag to support k8s 1.18 and I could have sworn I double-checked that it wasn't fixed in any other commit, but i was wrong. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org