Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

[Sai Boorlagadda <sb...@pivotal.io>]

> On May 24, 2016, 10:17 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java, line 1077
> > <https://reviews.apache.org/r/47793/diff/1/?file=1392875#file1392875line1077>
> >
> >     It looks to me like every place we call incrementBucketStats we also now do corresponding updates to dr inVM, onDisk, and BytesOnDisk.
> >     
> >     How about refactoring this code so that this common pattern is in a single method?
> >     You could rename incrementBucketStats to "updateOverflowStats" and add a DiskRegionView parameter.

I agree it needs some refactoring. Will create a new ticket for the re-factoring effort.


- Sai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47793/#review134647
-----------------------------------------------------------


On May 24, 2016, 9:36 p.m., Sai Boorlagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47793/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 9:36 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Ken Howe.
> 
> 
> Bugs: GEODE-93
>     https://issues.apache.org/jira/browse/GEODE-93
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> - Stats are not updated when a tombstone is scheduled/unscheduled.
> - All stats are updated when the data is finally flushed to the disk rather than doing it eagerly and compensating when on a new operation if the data is not yet written to disk
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java d28496cc6e58cf061ce996d45526f3a0bd3ab10f 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java 1a3277ca7b9597327e9ce42a61976ad731cc7c1c 
> 
> Diff: https://reviews.apache.org/r/47793/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>