You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/30 03:53:43 UTC
[GitHub] [flink] Thesharing commented on a change in pull request #19275: [FLINK-24491] Make the job termination wait until the archiving of ExecutionGraphInfo finishes
Thesharing commented on a change in pull request #19275:
URL: https://github.com/apache/flink/pull/19275#discussion_r838093153
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -618,12 +620,16 @@ private void runJob(JobManagerRunner jobManagerRunner, ExecutionType executionTy
getMainThreadExecutor());
final CompletableFuture<Void> jobTerminationFuture =
- cleanupJobStateFuture.thenCompose(
- cleanupJobState ->
- removeJob(jobId, cleanupJobState)
- .exceptionally(
- throwable ->
- logCleanupErrorWarning(jobId, throwable)));
+ cleanupJobStateFuture.thenComposeAsync(
+ (jobTerminalState) ->
Review comment:
```suggestion
jobTerminalState ->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org