You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/03 03:55:18 UTC
[GitHub] [cloudstack] jbampton opened a new pull request, #6606: Enable Flake8 rule W391
jbampton opened a new pull request, #6606:
URL: https://github.com/apache/cloudstack/pull/6606
Best practice is to have one blank line at the end of Python files.
Remove unneeded blank lines from the end of files
### Description
This PR standardizes the Python code.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1204075174
> Hey @DaanHoogland seems Flake8 is being run by the Super-Linter and that check passed.
>
> Can you please show me where Travis runs flake8 ?
If it does at all, it will be in the first job, https://app.travis-ci.com/github/apache/cloudstack/jobs/578591259
it was a genuine question and I guess you answered it ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
jbampton commented on PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1204012050
Hey @DaanHoogland seems Flake8 is being run by the Super-Linter and that check passed.
Can you please show me where Travis runs flake8 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1310277670
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1203974524
CLGTM and job one in travis succeeds. this should be the only test we need is it @jbampton ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6606: Enable Flake8 rule W391
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6606:
URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1310276388
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org