You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@hive.apache.org by Min Zhou <co...@gmail.com> on 2009/09/11 10:21:21 UTC
which thrift reversion do you use ?
Hi all,
we've tried newest one from trunk and r760184, both of them can't produce
the same code with hive trunk.
which thrift reversion do you use ?
Thanks,
Min
--
My research interests are distributed systems, parallel computing and
bytecode based virtual machine.
My profile:
http://www.linkedin.com/in/coderplay
My blog:
http://coderplay.javaeye.com
Re: which thrift reversion do you use ?
Posted by Min Zhou <co...@gmail.com>.
oops, I got the point. I was running it with different arguments on thrift.
Min
On Mon, Sep 14, 2009 at 12:39 PM, Min Zhou <co...@gmail.com> wrote:
> I am afraid I don't think so . Here is a diff between those two.
>
>
> diff gen-java/org/apache/hadoop/hive/service/ThriftHive.java
> service/src/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
>
> 600c600
> < public String query;
> ---
> > private String query;
> 657,662d656
> < public void setQueryIsSet(boolean value) {
> < if (!value) {
> < this.query = null;
> < }
> < }
> <
> 754,755d747
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 799c791
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 856,861d847
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 954,955d939
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 1080,1081d1063
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 1114c1096
> < public String success;
> ---
> > private String success;
> 1116c1098
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 1180,1185d1161
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 1203,1208d1178
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 1330,1331d1299
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 1386c1354
> < public int numRows;
> ---
> > private int numRows;
> 1445,1448d1412
> < public void setNumRowsIsSet(boolean value) {
> < this.__isset.numRows = value;
> < }
> <
> 1541,1542d1504
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 1581c1543
> < public List<String> success;
> ---
> > private List<String> success;
> 1583c1545
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 1667,1672d1628
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 1690,1695d1645
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 1827,1828d1776
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 1971,1972d1918
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 2005c1951
> < public List<String> success;
> ---
> > private List<String> success;
> 2007c1953
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 2091,2096d2036
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 2114,2119d2053
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 2251,2252d2184
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 2395,2396d2326
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 2429c2359
> < public org.apache.hadoop.hive.metastore.api.Schema success;
> ---
> > private org.apache.hadoop.hive.metastore.api.Schema success;
> 2431c2361
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 2495,2500d2424
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 2518,2523d2441
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 2646,2647d2563
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 2784,2785d2699
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 2818c2732
> < public org.apache.hadoop.hive.metastore.api.Schema success;
> ---
> > private org.apache.hadoop.hive.metastore.api.Schema success;
> 2820c2734
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 2884,2889d2797
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 2907,2912d2814
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 3035,3036d2936
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 3173,3174d3072
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 3207c3105
> < public HiveClusterStatus success;
> ---
> > private HiveClusterStatus success;
> 3209c3107
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 3273,3278d3170
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 3296,3301d3187
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 3424,3425d3309
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 3562,3563d3445
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
> 3596c3478
> < public org.apache.hadoop.hive.ql.plan.api.QueryPlan success;
> ---
> > private org.apache.hadoop.hive.ql.plan.api.QueryPlan success;
> 3598c3480
> < public HiveServerException ex;
> ---
> > private HiveServerException ex;
> 3662,3667d3543
> < public void setSuccessIsSet(boolean value) {
> < if (!value) {
> < this.success = null;
> < }
> < }
> <
> 3685,3690d3560
> < public void setExIsSet(boolean value) {
> < if (!value) {
> < this.ex = null;
> < }
> < }
> <
> 3813,3814d3682
> <
> < // check for required fields of primitive type, which can't be
> checked in the validate method
>
>
> Min
>
>
> On Mon, Sep 14, 2009 at 12:12 PM, Bill Graham <bi...@gmail.com>wrote:
>
>> I believe that's what Raghu is answering, which is the version of thrift
>> used on the trunk currently. I just referenced HIVE-795, since I needed the
>> same question answered to submit the last patch to that JIRA.
>>
>>
>> On Sun, Sep 13, 2009 at 9:01 PM, Min Zhou <co...@gmail.com> wrote:
>>
>>> Hi Raghu
>>>
>>> did you mean https://issues.apache.org/jira/browse/HIVE-795 ? but that
>>> patch hasn't been commit yet.
>>> I meant which thrift version is used in hive trunk.
>>>
>>> Thanks,
>>> Min
>>>
>>>
>>> On Sat, Sep 12, 2009 at 5:05 AM, Raghu Murthy <rm...@facebook.com>wrote:
>>>
>>>> I think we used r790732 the last time we made changes to the hive
>>>> service
>>>> interface.
>>>>
>>>> raghu
>>>>
>>>>
>>>> On 9/11/09 10:18 AM, "Bill Graham" <bi...@gmail.com> wrote:
>>>>
>>>> > +1
>>>> >
>>>> > I've been struggling with thrift versions as well, see:
>>>> >
>>>> https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=
>>>> >
>>>> com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_1275
>>>> > 4020
>>>> >
>>>> > Any insight into which version of thrift the Hive trunk is using would
>>>> be
>>>> > helpful.
>>>> >
>>>> >
>>>> >
>>>> > On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com>
>>>> wrote:
>>>> >> Hi all,
>>>> >>
>>>> >> we've tried newest one from trunk and r760184, both of them can't
>>>> produce the
>>>> >> same code with hive trunk.
>>>> >> which thrift reversion do you use ?
>>>> >>
>>>> >>
>>>> >> Thanks,
>>>> >> Min
>>>> >> --
>>>> >> My research interests are distributed systems, parallel computing and
>>>> >> bytecode
>>>> >> based virtual machine.
>>>> >>
>>>> >> My profile:
>>>> >> http://www.linkedin.com/in/coderplay
>>>> >> My blog:
>>>> >> http://coderplay.javaeye.com
>>>> >
>>>>
>>>>
>>>
>>>
>>> --
>>> My research interests are distributed systems, parallel computing and
>>> bytecode based virtual machine.
>>>
>>> My profile:
>>> http://www.linkedin.com/in/coderplay
>>> My blog:
>>> http://coderplay.javaeye.com
>>>
>>
>>
>
>
> --
> My research interests are distributed systems, parallel computing and
> bytecode based virtual machine.
>
> My profile:
> http://www.linkedin.com/in/coderplay
> My blog:
> http://coderplay.javaeye.com
>
--
My research interests are distributed systems, parallel computing and
bytecode based virtual machine.
My profile:
http://www.linkedin.com/in/coderplay
My blog:
http://coderplay.javaeye.com
Re: which thrift reversion do you use ?
Posted by Min Zhou <co...@gmail.com>.
I am afraid I don't think so . Here is a diff between those two.
diff gen-java/org/apache/hadoop/hive/service/ThriftHive.java
service/src/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
600c600
< public String query;
---
> private String query;
657,662d656
< public void setQueryIsSet(boolean value) {
< if (!value) {
< this.query = null;
< }
< }
<
754,755d747
<
< // check for required fields of primitive type, which can't be
checked in the validate method
799c791
< public HiveServerException ex;
---
> private HiveServerException ex;
856,861d847
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
954,955d939
<
< // check for required fields of primitive type, which can't be
checked in the validate method
1080,1081d1063
<
< // check for required fields of primitive type, which can't be
checked in the validate method
1114c1096
< public String success;
---
> private String success;
1116c1098
< public HiveServerException ex;
---
> private HiveServerException ex;
1180,1185d1161
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
1203,1208d1178
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
1330,1331d1299
<
< // check for required fields of primitive type, which can't be
checked in the validate method
1386c1354
< public int numRows;
---
> private int numRows;
1445,1448d1412
< public void setNumRowsIsSet(boolean value) {
< this.__isset.numRows = value;
< }
<
1541,1542d1504
<
< // check for required fields of primitive type, which can't be
checked in the validate method
1581c1543
< public List<String> success;
---
> private List<String> success;
1583c1545
< public HiveServerException ex;
---
> private HiveServerException ex;
1667,1672d1628
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
1690,1695d1645
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
1827,1828d1776
<
< // check for required fields of primitive type, which can't be
checked in the validate method
1971,1972d1918
<
< // check for required fields of primitive type, which can't be
checked in the validate method
2005c1951
< public List<String> success;
---
> private List<String> success;
2007c1953
< public HiveServerException ex;
---
> private HiveServerException ex;
2091,2096d2036
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
2114,2119d2053
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
2251,2252d2184
<
< // check for required fields of primitive type, which can't be
checked in the validate method
2395,2396d2326
<
< // check for required fields of primitive type, which can't be
checked in the validate method
2429c2359
< public org.apache.hadoop.hive.metastore.api.Schema success;
---
> private org.apache.hadoop.hive.metastore.api.Schema success;
2431c2361
< public HiveServerException ex;
---
> private HiveServerException ex;
2495,2500d2424
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
2518,2523d2441
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
2646,2647d2563
<
< // check for required fields of primitive type, which can't be
checked in the validate method
2784,2785d2699
<
< // check for required fields of primitive type, which can't be
checked in the validate method
2818c2732
< public org.apache.hadoop.hive.metastore.api.Schema success;
---
> private org.apache.hadoop.hive.metastore.api.Schema success;
2820c2734
< public HiveServerException ex;
---
> private HiveServerException ex;
2884,2889d2797
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
2907,2912d2814
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
3035,3036d2936
<
< // check for required fields of primitive type, which can't be
checked in the validate method
3173,3174d3072
<
< // check for required fields of primitive type, which can't be
checked in the validate method
3207c3105
< public HiveClusterStatus success;
---
> private HiveClusterStatus success;
3209c3107
< public HiveServerException ex;
---
> private HiveServerException ex;
3273,3278d3170
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
3296,3301d3187
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
3424,3425d3309
<
< // check for required fields of primitive type, which can't be
checked in the validate method
3562,3563d3445
<
< // check for required fields of primitive type, which can't be
checked in the validate method
3596c3478
< public org.apache.hadoop.hive.ql.plan.api.QueryPlan success;
---
> private org.apache.hadoop.hive.ql.plan.api.QueryPlan success;
3598c3480
< public HiveServerException ex;
---
> private HiveServerException ex;
3662,3667d3543
< public void setSuccessIsSet(boolean value) {
< if (!value) {
< this.success = null;
< }
< }
<
3685,3690d3560
< public void setExIsSet(boolean value) {
< if (!value) {
< this.ex = null;
< }
< }
<
3813,3814d3682
<
< // check for required fields of primitive type, which can't be
checked in the validate method
Min
On Mon, Sep 14, 2009 at 12:12 PM, Bill Graham <bi...@gmail.com> wrote:
> I believe that's what Raghu is answering, which is the version of thrift
> used on the trunk currently. I just referenced HIVE-795, since I needed the
> same question answered to submit the last patch to that JIRA.
>
>
> On Sun, Sep 13, 2009 at 9:01 PM, Min Zhou <co...@gmail.com> wrote:
>
>> Hi Raghu
>>
>> did you mean https://issues.apache.org/jira/browse/HIVE-795 ? but that
>> patch hasn't been commit yet.
>> I meant which thrift version is used in hive trunk.
>>
>> Thanks,
>> Min
>>
>>
>> On Sat, Sep 12, 2009 at 5:05 AM, Raghu Murthy <rm...@facebook.com>wrote:
>>
>>> I think we used r790732 the last time we made changes to the hive service
>>> interface.
>>>
>>> raghu
>>>
>>>
>>> On 9/11/09 10:18 AM, "Bill Graham" <bi...@gmail.com> wrote:
>>>
>>> > +1
>>> >
>>> > I've been struggling with thrift versions as well, see:
>>> >
>>> https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=
>>> >
>>> com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_1275
>>> > 4020
>>> >
>>> > Any insight into which version of thrift the Hive trunk is using would
>>> be
>>> > helpful.
>>> >
>>> >
>>> >
>>> > On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com> wrote:
>>> >> Hi all,
>>> >>
>>> >> we've tried newest one from trunk and r760184, both of them can't
>>> produce the
>>> >> same code with hive trunk.
>>> >> which thrift reversion do you use ?
>>> >>
>>> >>
>>> >> Thanks,
>>> >> Min
>>> >> --
>>> >> My research interests are distributed systems, parallel computing and
>>> >> bytecode
>>> >> based virtual machine.
>>> >>
>>> >> My profile:
>>> >> http://www.linkedin.com/in/coderplay
>>> >> My blog:
>>> >> http://coderplay.javaeye.com
>>> >
>>>
>>>
>>
>>
>> --
>> My research interests are distributed systems, parallel computing and
>> bytecode based virtual machine.
>>
>> My profile:
>> http://www.linkedin.com/in/coderplay
>> My blog:
>> http://coderplay.javaeye.com
>>
>
>
--
My research interests are distributed systems, parallel computing and
bytecode based virtual machine.
My profile:
http://www.linkedin.com/in/coderplay
My blog:
http://coderplay.javaeye.com
Re: which thrift reversion do you use ?
Posted by Bill Graham <bi...@gmail.com>.
I believe that's what Raghu is answering, which is the version of thrift
used on the trunk currently. I just referenced HIVE-795, since I needed the
same question answered to submit the last patch to that JIRA.
On Sun, Sep 13, 2009 at 9:01 PM, Min Zhou <co...@gmail.com> wrote:
> Hi Raghu
>
> did you mean https://issues.apache.org/jira/browse/HIVE-795 ? but that
> patch hasn't been commit yet.
> I meant which thrift version is used in hive trunk.
>
> Thanks,
> Min
>
>
> On Sat, Sep 12, 2009 at 5:05 AM, Raghu Murthy <rm...@facebook.com>wrote:
>
>> I think we used r790732 the last time we made changes to the hive service
>> interface.
>>
>> raghu
>>
>>
>> On 9/11/09 10:18 AM, "Bill Graham" <bi...@gmail.com> wrote:
>>
>> > +1
>> >
>> > I've been struggling with thrift versions as well, see:
>> >
>> https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=
>> >
>> com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_1275
>> > 4020
>> >
>> > Any insight into which version of thrift the Hive trunk is using would
>> be
>> > helpful.
>> >
>> >
>> >
>> > On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com> wrote:
>> >> Hi all,
>> >>
>> >> we've tried newest one from trunk and r760184, both of them can't
>> produce the
>> >> same code with hive trunk.
>> >> which thrift reversion do you use ?
>> >>
>> >>
>> >> Thanks,
>> >> Min
>> >> --
>> >> My research interests are distributed systems, parallel computing and
>> >> bytecode
>> >> based virtual machine.
>> >>
>> >> My profile:
>> >> http://www.linkedin.com/in/coderplay
>> >> My blog:
>> >> http://coderplay.javaeye.com
>> >
>>
>>
>
>
> --
> My research interests are distributed systems, parallel computing and
> bytecode based virtual machine.
>
> My profile:
> http://www.linkedin.com/in/coderplay
> My blog:
> http://coderplay.javaeye.com
>
Re: which thrift reversion do you use ?
Posted by Min Zhou <co...@gmail.com>.
Hi Raghu
did you mean https://issues.apache.org/jira/browse/HIVE-795 ? but that patch
hasn't been commit yet.
I meant which thrift version is used in hive trunk.
Thanks,
Min
On Sat, Sep 12, 2009 at 5:05 AM, Raghu Murthy <rm...@facebook.com> wrote:
> I think we used r790732 the last time we made changes to the hive service
> interface.
>
> raghu
>
>
> On 9/11/09 10:18 AM, "Bill Graham" <bi...@gmail.com> wrote:
>
> > +1
> >
> > I've been struggling with thrift versions as well, see:
> >
> https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=
> >
> com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_1275
> > 4020
> >
> > Any insight into which version of thrift the Hive trunk is using would be
> > helpful.
> >
> >
> >
> > On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com> wrote:
> >> Hi all,
> >>
> >> we've tried newest one from trunk and r760184, both of them can't
> produce the
> >> same code with hive trunk.
> >> which thrift reversion do you use ?
> >>
> >>
> >> Thanks,
> >> Min
> >> --
> >> My research interests are distributed systems, parallel computing and
> >> bytecode
> >> based virtual machine.
> >>
> >> My profile:
> >> http://www.linkedin.com/in/coderplay
> >> My blog:
> >> http://coderplay.javaeye.com
> >
>
>
--
My research interests are distributed systems, parallel computing and
bytecode based virtual machine.
My profile:
http://www.linkedin.com/in/coderplay
My blog:
http://coderplay.javaeye.com
Re: which thrift reversion do you use ?
Posted by Raghu Murthy <rm...@facebook.com>.
I think we used r790732 the last time we made changes to the hive service
interface.
raghu
On 9/11/09 10:18 AM, "Bill Graham" <bi...@gmail.com> wrote:
> +1
>
> I've been struggling with thrift versions as well, see:
> https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=
> com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_1275
> 4020
>
> Any insight into which version of thrift the Hive trunk is using would be
> helpful.
>
>
>
> On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com> wrote:
>> Hi all,
>>
>> we've tried newest one from trunk and r760184, both of them can't produce the
>> same code with hive trunk.
>> which thrift reversion do you use ?
>>
>>
>> Thanks,
>> Min
>> --
>> My research interests are distributed systems, parallel computing and
>> bytecode
>> based virtual machine.
>>
>> My profile:
>> http://www.linkedin.com/in/coderplay
>> My blog:
>> http://coderplay.javaeye.com
>
Re: which thrift reversion do you use ?
Posted by Bill Graham <bi...@gmail.com>.
+1
I've been struggling with thrift versions as well, see:
https://issues.apache.org/jira/browse/HIVE-795?focusedCommentId=12754020&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12754020
Any insight into which version of thrift the Hive trunk is using would be
helpful.
On Fri, Sep 11, 2009 at 1:21 AM, Min Zhou <co...@gmail.com> wrote:
> Hi all,
>
> we've tried newest one from trunk and r760184, both of them can't produce
> the same code with hive trunk.
> which thrift reversion do you use ?
>
>
> Thanks,
> Min
> --
> My research interests are distributed systems, parallel computing and
> bytecode based virtual machine.
>
> My profile:
> http://www.linkedin.com/in/coderplay
> My blog:
> http://coderplay.javaeye.com
>