You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Eero Nevalainen (JIRA)" <ji...@apache.org> on 2007/07/09 14:41:04 UTC
[jira] Created: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
--------------------------------------------------------------------------------
Key: DIRMINA-397
URL: https://issues.apache.org/jira/browse/DIRMINA-397
Project: MINA
Issue Type: Improvement
Components: Filter
Reporter: Eero Nevalainen
Priority: Minor
Change the following
public TextLineCodecFactory( Charset charset )
{
encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
}
to
public TextLineCodecFactory( Charset charset )
{
this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
}
public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
{
encoder = new TextLineEncoder( charset, encodingDelimiter );
decoder = new TextLineDecoder( charset, decodingDelimiter );
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Posted by "Eero Nevalainen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eero Nevalainen closed DIRMINA-397.
-----------------------------------
Ok then. Re-closing the issue.
> Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-397
> URL: https://issues.apache.org/jira/browse/DIRMINA-397
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Reporter: Eero Nevalainen
> Assignee: Mark Webb
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Change the following
> public TextLineCodecFactory( Charset charset )
> {
> encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
> decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
> }
> to
> public TextLineCodecFactory( Charset charset )
> {
> this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
> }
> public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
> {
> encoder = new TextLineEncoder( charset, encodingDelimiter );
> decoder = new TextLineDecoder( charset, decodingDelimiter );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Posted by "Eero Nevalainen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511103 ]
Eero Nevalainen commented on DIRMINA-397:
-----------------------------------------
It seems I'm not the only one who needs to set the delimiters manually. Although TextLineEncoder and Decoder can be used directly to the same effect this change would make my code a little bit prettier.
> Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-397
> URL: https://issues.apache.org/jira/browse/DIRMINA-397
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Reporter: Eero Nevalainen
> Priority: Minor
>
> Change the following
> public TextLineCodecFactory( Charset charset )
> {
> encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
> decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
> }
> to
> public TextLineCodecFactory( Charset charset )
> {
> this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
> }
> public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
> {
> encoder = new TextLineEncoder( charset, encodingDelimiter );
> decoder = new TextLineDecoder( charset, decodingDelimiter );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Posted by "Eero Nevalainen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eero Nevalainen reopened DIRMINA-397:
-------------------------------------
Can we get this to the 1.1 and 1.0 branches as well?
> Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-397
> URL: https://issues.apache.org/jira/browse/DIRMINA-397
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Reporter: Eero Nevalainen
> Assignee: Mark Webb
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Change the following
> public TextLineCodecFactory( Charset charset )
> {
> encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
> decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
> }
> to
> public TextLineCodecFactory( Charset charset )
> {
> this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
> }
> public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
> {
> encoder = new TextLineEncoder( charset, encodingDelimiter );
> decoder = new TextLineDecoder( charset, decodingDelimiter );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Webb closed DIRMINA-397.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-M1
Assignee: Mark Webb
Added the constructor that was requested. Also updated the javadoc for the constructor that takes in a Charset object.
> Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-397
> URL: https://issues.apache.org/jira/browse/DIRMINA-397
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Reporter: Eero Nevalainen
> Assignee: Mark Webb
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Change the following
> public TextLineCodecFactory( Charset charset )
> {
> encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
> decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
> }
> to
> public TextLineCodecFactory( Charset charset )
> {
> this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
> }
> public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
> {
> encoder = new TextLineEncoder( charset, encodingDelimiter );
> decoder = new TextLineDecoder( charset, decodingDelimiter );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-397) Add convenience constructor for
specifying linedelimiter in TextLineCodecFactory
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee resolved DIRMINA-397.
---------------------------------
Resolution: Fixed
Unfortunately not. Any API changes and addition will go to trunk, as Apache MINA project team discussed long ago. We will do our best to release 2.0.0-M1 as soon as possible. Actually, we started to find the fastest way to release the new major release:
http://www.nabble.com/-POLL--What-do-you-expect-in-MINA-2.0.0-M1--tf4205346s16868.html
Please tell us which issues are important and which are not. Then we can release sooner!
> Add convenience constructor for specifying linedelimiter in TextLineCodecFactory
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-397
> URL: https://issues.apache.org/jira/browse/DIRMINA-397
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Reporter: Eero Nevalainen
> Assignee: Mark Webb
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Change the following
> public TextLineCodecFactory( Charset charset )
> {
> encoder = new TextLineEncoder( charset, LineDelimiter.UNIX );
> decoder = new TextLineDecoder( charset, LineDelimiter.AUTO );
> }
> to
> public TextLineCodecFactory( Charset charset )
> {
> this( charset, LineDelimiter.UNIX, LineDelimiter.AUTO );
> }
> public TextLineCodecFactory( Charset charset, LineDelimiter encodingDelimiter, LineDelimiter decodingDelimiter )
> {
> encoder = new TextLineEncoder( charset, encodingDelimiter );
> decoder = new TextLineDecoder( charset, decodingDelimiter );
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.