You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/13 05:22:28 UTC

[GitHub] [apisix-dashboard] tzssangglass opened a new issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

tzssangglass opened a new issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977


   # Feature request
   
   first we need to support the configuration of `discovery_type` and `service_name`
   
   related issue https://github.com/apache/apisix-dashboard/issues/1911
                          https://github.com/apache/apisix-dashboard/issues/1549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

nic-chen commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901818836


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] spacewander commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

spacewander commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901590902


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-878868199


   Just updated your first comment, and I will take this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

Baoyuantop commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901879813


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

bzp2010 commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901889703


   This issue is similar to issue #1989, and I will try it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901569744


   https://github.com/apache/apisix-dashboard/pull/1557
   
   BE has already support this feature, remove `backend` tag


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 closed issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

bzp2010 closed issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901584538


   Refer to the https://apisix.apache.org/docs/apisix/2.7/discovery#supported-discovery-registries
   
   In APISIX2.7 , we support Eureka/Consul/Nacos and service discovery via DNS,
   
   in order to support this feature in dashboard, we have to update our `Upstream` module,  add `Target type` filed, user can choose `Node` or `Service Discovery`
   
   when choose `Node`, user can complete the follow fields:
   ![image](https://user-images.githubusercontent.com/2561857/130003249-04101972-7660-4f01-8520-127a82b96574.png)
   
   When choose `Service Discovery`, user can complete the following fields:
   `discovery_type`, a list of `dns`、`consul_kv` `nacos` and `eureka`
   `service_name `, input the your configured service name
   
   It should be noted that, when `discovery_type` choose `nacos`, `discovery_args` can be configured, see: https://apisix.apache.org/docs/apisix/2.7/discovery/nacos#discovery_args for details.
   
   cc @bzp2010 @juzhiyuan @Baoyuantop @tzssangglass @nic-chen @spacewander to help to check whether I missed some thing for this feature, thanks a lot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 closed issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

bzp2010 closed issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 closed issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

bzp2010 closed issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1977: feat: dashboard supports selecting: Service Discovery when creating an upstream

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1977:
URL: https://github.com/apache/apisix-dashboard/issues/1977#issuecomment-901628188


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org