You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Anton Mushin <An...@epam.com> on 2016/12/03 19:18:10 UTC
[FLINK-4704 ] Move Table API to org.apache.flink.table
Hi devs,
I would to do FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
Where do need move these classes? Is simple in
`org.apache.flink.table` pacage?
What do you still think about move Table API classes?
[1]https://issues.apache.org/jira/browse/FLINK-4704
Best regards,
Anton Mushin
RE: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Anton Mushin <An...@epam.com>.
Hi, Timo
PR created: https://github.com/apache/flink/pull/2958
Best regards,
Anton Mushin
-----Original Message-----
From: Anton Mushin [mailto:Anton_Mushin@epam.com]
Sent: Tuesday, December 06, 2016 6:30 PM
To: dev@flink.apache.org
Cc: Timo Walther <tw...@apache.org>
Subject: RE: [FLINK-4704 ] Move Table API to org.apache.flink.table
Hi Timo,
I try implement issue tomorrow and create PR.
Best regards,
Anton Mushin
-----Original Message-----
From: Timo Walther [mailto:twalthr@apache.org]
Sent: Tuesday, December 06, 2016 2:42 PM
To: dev@flink.apache.org
Cc: Anton Mushin <An...@epam.com>
Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Hi Anton,
sorry, it seems that I was misinformed. The feature freeze might happen next week already.
Do you think you can work on this issue this week or beginning of next week? Feel free to assign it to you.
Regards,
Timo
Am 05/12/16 um 09:37 schrieb Anton Mushin:
> Hi Timo,
> Ok.
> In this time this issue assign to you. If you will have no objection early in January I would assign to me this issue and implement.
>
> Best regards,
> Anton Mushin
>
> -----Original Message-----
> From: Timo Walther [mailto:twalthr@apache.org]
> Sent: Monday, December 05, 2016 12:23 PM
> To: dev@flink.apache.org
> Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
>
> Hi Anton,
>
> thanks for bringing up this discussion and volunteering. Yes we should do that before the 1.2 release. You can assign the issue to you if you like. However, we should first get most of the pull requests in (esp.
> the large PRs). The next release is still some weeks away so it make sense to do the refactoring early in January.
>
> User-facing classes (API classes) should be moved to org.apache.flink.table.java/scala. All other stuff such as logical nodes, expressions, code gen should be in org.apache.flink.table.
>
> Regars,
> Timo
>
>
> Am 05/12/16 um 09:07 schrieb Jark Wu:
>> +1
>>
>> I would like to move these classes into `org.apache.flink.table.api`
>> , and move Java `BatchTableEnvironment.scala` into
>> `org.apache.flink.table.api.java`,
>> and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
>>
>> - Jark Wu
>>
>>> 在 2016年12月4日，上午3:18，Anton Mushin <An...@epam.com> 写道：
>>>
>>> Hi devs,
>>>
>>> I would to do
>>> FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>>>
>>>
>>> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>>>
>>> Where do need move these classes? Is simple in
>>>
>>> `org.apache.flink.table` pacage?
>>>
>>>
>>> What do you still think about move Table API classes?
>>>
>>>
>>> [1]https://issues.apache.org/jira/browse/FLINK-4704
>>>
>>>
>>> Best regards,
>>> Anton Mushin
RE: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Anton Mushin <An...@epam.com>.
Hi Timo,
I try implement issue tomorrow and create PR.
Best regards,
Anton Mushin
-----Original Message-----
From: Timo Walther [mailto:twalthr@apache.org]
Sent: Tuesday, December 06, 2016 2:42 PM
To: dev@flink.apache.org
Cc: Anton Mushin <An...@epam.com>
Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Hi Anton,
sorry, it seems that I was misinformed. The feature freeze might happen next week already.
Do you think you can work on this issue this week or beginning of next week? Feel free to assign it to you.
Regards,
Timo
Am 05/12/16 um 09:37 schrieb Anton Mushin:
> Hi Timo,
> Ok.
> In this time this issue assign to you. If you will have no objection early in January I would assign to me this issue and implement.
>
> Best regards,
> Anton Mushin
>
> -----Original Message-----
> From: Timo Walther [mailto:twalthr@apache.org]
> Sent: Monday, December 05, 2016 12:23 PM
> To: dev@flink.apache.org
> Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
>
> Hi Anton,
>
> thanks for bringing up this discussion and volunteering. Yes we should do that before the 1.2 release. You can assign the issue to you if you like. However, we should first get most of the pull requests in (esp.
> the large PRs). The next release is still some weeks away so it make sense to do the refactoring early in January.
>
> User-facing classes (API classes) should be moved to org.apache.flink.table.java/scala. All other stuff such as logical nodes, expressions, code gen should be in org.apache.flink.table.
>
> Regars,
> Timo
>
>
> Am 05/12/16 um 09:07 schrieb Jark Wu:
>> +1
>>
>> I would like to move these classes into `org.apache.flink.table.api`
>> , and move Java `BatchTableEnvironment.scala` into
>> `org.apache.flink.table.api.java`,
>> and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
>>
>> - Jark Wu
>>
>>> 在 2016年12月4日，上午3:18，Anton Mushin <An...@epam.com> 写道：
>>>
>>> Hi devs,
>>>
>>> I would to do
>>> FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>>>
>>>
>>> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>>>
>>> Where do need move these classes? Is simple in
>>>
>>> `org.apache.flink.table` pacage?
>>>
>>>
>>> What do you still think about move Table API classes?
>>>
>>>
>>> [1]https://issues.apache.org/jira/browse/FLINK-4704
>>>
>>>
>>> Best regards,
>>> Anton Mushin
Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Timo Walther <tw...@apache.org>.
Hi Anton,
sorry, it seems that I was misinformed. The feature freeze might happen
next week already.
Do you think you can work on this issue this week or beginning of next
week? Feel free to assign it to you.
Regards,
Timo
Am 05/12/16 um 09:37 schrieb Anton Mushin:
> Hi Timo,
> Ok.
> In this time this issue assign to you. If you will have no objection early in January I would assign to me this issue and implement.
>
> Best regards,
> Anton Mushin
>
> -----Original Message-----
> From: Timo Walther [mailto:twalthr@apache.org]
> Sent: Monday, December 05, 2016 12:23 PM
> To: dev@flink.apache.org
> Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
>
> Hi Anton,
>
> thanks for bringing up this discussion and volunteering. Yes we should do that before the 1.2 release. You can assign the issue to you if you like. However, we should first get most of the pull requests in (esp.
> the large PRs). The next release is still some weeks away so it make sense to do the refactoring early in January.
>
> User-facing classes (API classes) should be moved to org.apache.flink.table.java/scala. All other stuff such as logical nodes, expressions, code gen should be in org.apache.flink.table.
>
> Regars,
> Timo
>
>
> Am 05/12/16 um 09:07 schrieb Jark Wu:
>> +1
>>
>> I would like to move these classes into `org.apache.flink.table.api` ,
>> and move Java `BatchTableEnvironment.scala` into
>> `org.apache.flink.table.api.java`,
>> and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
>>
>> - Jark Wu
>>
>>> 在 2016年12月4日，上午3:18，Anton Mushin <An...@epam.com> 写道：
>>>
>>> Hi devs,
>>>
>>> I would to do
>>> FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>>>
>>>
>>> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>>>
>>> Where do need move these classes? Is simple in
>>>
>>> `org.apache.flink.table` pacage?
>>>
>>>
>>> What do you still think about move Table API classes?
>>>
>>>
>>> [1]https://issues.apache.org/jira/browse/FLINK-4704
>>>
>>>
>>> Best regards,
>>> Anton Mushin
RE: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Anton Mushin <An...@epam.com>.
Hi Timo,
Ok.
In this time this issue assign to you. If you will have no objection early in January I would assign to me this issue and implement.
Best regards,
Anton Mushin
-----Original Message-----
From: Timo Walther [mailto:twalthr@apache.org]
Sent: Monday, December 05, 2016 12:23 PM
To: dev@flink.apache.org
Subject: Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Hi Anton,
thanks for bringing up this discussion and volunteering. Yes we should do that before the 1.2 release. You can assign the issue to you if you like. However, we should first get most of the pull requests in (esp.
the large PRs). The next release is still some weeks away so it make sense to do the refactoring early in January.
User-facing classes (API classes) should be moved to org.apache.flink.table.java/scala. All other stuff such as logical nodes, expressions, code gen should be in org.apache.flink.table.
Regars,
Timo
Am 05/12/16 um 09:07 schrieb Jark Wu:
> +1
>
> I would like to move these classes into `org.apache.flink.table.api` ,
> and move Java `BatchTableEnvironment.scala` into
> `org.apache.flink.table.api.java`,
> and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
>
> - Jark Wu
>
>> 在 2016年12月4日，上午3:18，Anton Mushin <An...@epam.com> 写道：
>>
>> Hi devs,
>>
>> I would to do
>> FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>>
>>
>> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>>
>> Where do need move these classes? Is simple in
>>
>> `org.apache.flink.table` pacage?
>>
>>
>> What do you still think about move Table API classes?
>>
>>
>> [1]https://issues.apache.org/jira/browse/FLINK-4704
>>
>>
>> Best regards,
>> Anton Mushin
>
Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Timo Walther <tw...@apache.org>.
Hi Anton,
thanks for bringing up this discussion and volunteering. Yes we should
do that before the 1.2 release. You can assign the issue to you if you
like. However, we should first get most of the pull requests in (esp.
the large PRs). The next release is still some weeks away so it make
sense to do the refactoring early in January.
User-facing classes (API classes) should be moved to
org.apache.flink.table.java/scala. All other stuff such as logical
nodes, expressions, code gen should be in org.apache.flink.table.
Regars,
Timo
Am 05/12/16 um 09:07 schrieb Jark Wu:
> +1
>
> I would like to move these classes into `org.apache.flink.table.api` , and move Java `BatchTableEnvironment.scala` into `org.apache.flink.table.api.java`,
> and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
>
> - Jark Wu
>
>> 2016124\u05633:18Anton Mushin <An...@epam.com> \u0434
>>
>> Hi devs,
>>
>> I would to do FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>>
>>
>> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>>
>> Where do need move these classes? Is simple in
>>
>> `org.apache.flink.table` pacage?
>>
>>
>> What do you still think about move Table API classes?
>>
>>
>> [1]https://issues.apache.org/jira/browse/FLINK-4704
>>
>>
>> Best regards,
>> Anton Mushin
>
Re: [FLINK-4704 ] Move Table API to org.apache.flink.table
Posted by Jark Wu <wu...@alibaba-inc.com>.
+1
I would like to move these classes into `org.apache.flink.table.api` , and move Java `BatchTableEnvironment.scala` into `org.apache.flink.table.api.java`,
and Scala `BatchTableEnvironment.scala` into `org.apache.flink.table.api.scala`.
- Jark Wu
> 在 2016年12月4日，上午3:18，Anton Mushin <An...@epam.com> 写道：
>
> Hi devs,
>
> I would to do FLINK-4704<https://issues.apache.org/jira/browse/FLINK-4704> [1]
>
>
> In this time the special classes like as `BatchTableEnvironment.scala`, `Row.scala` and all expressions, codogen classes etc is in `org.apache.flink.api.table` package of scala table api module.
>
> Where do need move these classes? Is simple in
>
> `org.apache.flink.table` pacage?
>
>
> What do you still think about move Table API classes?
>
>
> [1]https://issues.apache.org/jira/browse/FLINK-4704
>
>
> Best regards,
> Anton Mushin