[GitHub] [tvm] mbrookhart commented on a diff in pull request #12131: [TFLite][CI] Update TensorFlow dependency to 2.9.1

[GitBox <gi...@apache.org>]

mbrookhart commented on code in PR #12131:
URL: https://github.com/apache/tvm/pull/12131#discussion_r961861487


##########
docker/Dockerfile.ci_cpu:
##########
@@ -136,3 +139,7 @@ ENV PATH /opt/sccache:$PATH
 # Libxsmm deps
 COPY install/ubuntu_install_libxsmm.sh /install
 RUN bash /install/ubuntu_install_libxsmm.sh
+
+# Hacky workaround (do not push to GitHub) to install the right Numpy version

Review Comment:
   Little concered about a comment that says "do not push to Github" in a github PR...



##########
docker/install/ubuntu_install_cmake_source.sh:
##########
@@ -20,8 +20,8 @@ set -e
 set -u
 set -o pipefail
 
-v=3.14
-version=3.14.7
+v=3.22

Review Comment:
   Do we need to update the minimum cmake version in the cmake file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org