[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9339: ARROW-11394: [Rust] Slice & Concat

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #9339:
URL: https://github.com/apache/arrow/pull/9339#discussion_r565511184



##########
File path: rust/arrow/src/array/transform/mod.rs
##########
@@ -714,6 +714,48 @@ mod tests {
         assert_eq!(array, expected)
     }
 
+    #[test]
+    fn test_struct_offset() {
+        let strings: ArrayRef = Arc::new(StringArray::from(vec![
+            Some("joe"),
+            None,
+            None,
+            Some("mark"),
+            Some("doe"),
+        ]));
+        let ints: ArrayRef = Arc::new(Int32Array::from(vec![
+            Some(1),
+            Some(2),
+            Some(3),
+            Some(4),
+            Some(5),
+        ]));
+
+        let array =
+            StructArray::try_from(vec![("f1", strings.clone()), ("f2", ints.clone())])
+                .unwrap()
+                .slice(1, 3)
+                .data();
+        let arrays = vec![array.as_ref()];
+        let mut mutable = MutableArrayData::new(arrays, false, 0);
+
+        mutable.extend(0, 1, 3);
+        let data = mutable.freeze();
+        let array = StructArray::from(Arc::new(data));
+
+        // Struct equality doesn't seem to work when using slices?

Review comment:
       Related to #9211 . When we `slice` an array, we increase its `offset`. However, for StructArrays, I think that we also need to increase the offset of the childs (or something like that). :(




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org