You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2011/12/05 10:29:45 UTC
Review Request: HIVE-2005 Implement BETWEEN operator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
Review request for hive, John Sichi and Carl Steinbach.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c7342c8
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
> On 2011-12-06 05:29:34, Carl Steinbach wrote:
> > * show_functions.q.out needs to be updated. There might be other test diffs too.
added already (r2)
> On 2011-12-06 05:29:34, Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java, line 1
> > <https://reviews.apache.org/r/3008/diff/2/?file=62038#file62038line1>
> >
> > Missing ASF License header.
ah, ok.
> On 2011-12-06 05:29:34, Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 356
> > <https://reviews.apache.org/r/3008/diff/2/?file=62036#file62036line356>
> >
> > Is it possible to register this as "between", or does that result in syntax errors?
I remember naming 'between' made a parsing exception. I'll try one more time.
> On 2011-12-06 05:29:34, Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java, line 15
> > <https://reviews.apache.org/r/3008/diff/2/?file=62038#file62038line15>
> >
> > Since we still end up expressing this as two UDFs, would it make more sense to implement this as a rewrite rule in the parser instead of as its own UDF? Implementing it as a special purpose UDF results in it appearing in the FunctionRegistry, and in the output of "show functions", which isn't super desirable for things that are fundamentally syntactic sugar.
The first version was implemented by using rewrite rule, something like 'A BETWEEN B AND C' --> 'B <= A AND A <= C'. But this made target expression(A) evaluated twice which made some queries slow. But I agree on the 'syntactic sugar' part.
Making system functions not visible was requested before (to me). Would it be useful for the problem?
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3656
-----------------------------------------------------------
On 2011-12-06 00:17:31, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-06 00:17:31)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c7342c8
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 05b784b
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3656
-----------------------------------------------------------
* show_functions.q.out needs to be updated. There might be other test diffs too.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/3008/#comment8158>
Is it possible to register this as "between", or does that result in syntax errors?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java
<https://reviews.apache.org/r/3008/#comment8157>
Missing ASF License header.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java
<https://reviews.apache.org/r/3008/#comment8159>
Since we still end up expressing this as two UDFs, would it make more sense to implement this as a rewrite rule in the parser instead of as its own UDF? Implementing it as a special purpose UDF results in it appearing in the FunctionRegistry, and in the output of "show functions", which isn't super desirable for things that are fundamentally syntactic sugar.
- Carl
On 2011-12-06 00:17:31, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-06 00:17:31)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c7342c8
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 05b784b
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3946
-----------------------------------------------------------
Ship it!
+1. Please upload this version of the patch to JIRA and click the box that grants license rights to the ASF. I will test and then commit if everything passes. Thanks.
- Carl
On 2011-12-16 04:23:03, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 04:23:03)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
(Updated 2011-12-16 04:23:03.804398)
Review request for hive, John Sichi and Carl Steinbach.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out e63516d
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Carl Steinbach <ca...@cloudera.com>.
> On 2011-12-16 03:26:25, Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/udf_between.q, line 1
> > <https://reviews.apache.org/r/3008/diff/5/?file=64857#file64857line1>
> >
> > I'm not sure why you changed this testcase. The original version was better.
> >
> > * The first two lines should be:
> > DESCRIBE FUNCTION between
> > DESCRIBE FUNCTION EXTENDED between;
> >
> > * Please call EXPLAIN on each query before running it.
> >
> > * Is there any reason in particular why you create the T1 table instead of reusing the 'src' table that gets created automatically for all CliDriver tests? Loading data will definitely make the test run more slowly.
>
> Navis Ryu wrote:
> Cause renaming 'btw' to 'between' made impossible to compile queries like 'SELECT between(false, 'b', 'a', 'c') FROM src LIMIT 1;'. Could you give me some better test queries?
>
> I'll add DESCRIBE part and EXPLAIN part, shortly.
Here's what I think it should look like:
DESCRIBE FUNCTION between;
DESCRIBE FUNCTION EXTENDED between;
EXPLAIN SELECT * FROM src WHERE key BETWEEN 2 AND 7;
SELECT * FROM src WHERE key BETWEEN 2 AND 7;
EXPLAIN SELECT * FROM src WHERE key NOT BETWEEN 2 AND 7;
SELECT * FROM src WHERE key NOT BETWEEN 2 AND 7;
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3943
-----------------------------------------------------------
On 2011-12-16 02:09:08, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 02:09:08)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
> On 2011-12-16 03:26:25, Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/udf_between.q, line 1
> > <https://reviews.apache.org/r/3008/diff/5/?file=64857#file64857line1>
> >
> > I'm not sure why you changed this testcase. The original version was better.
> >
> > * The first two lines should be:
> > DESCRIBE FUNCTION between
> > DESCRIBE FUNCTION EXTENDED between;
> >
> > * Please call EXPLAIN on each query before running it.
> >
> > * Is there any reason in particular why you create the T1 table instead of reusing the 'src' table that gets created automatically for all CliDriver tests? Loading data will definitely make the test run more slowly.
Cause renaming 'btw' to 'between' made impossible to compile queries like 'SELECT between(false, 'b', 'a', 'c') FROM src LIMIT 1;'. Could you give me some better test queries?
I'll add DESCRIBE part and EXPLAIN part, shortly.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3943
-----------------------------------------------------------
On 2011-12-16 02:09:08, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 02:09:08)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3943
-----------------------------------------------------------
Please update udf_bewteen.q and then attach the updated patch to HIVE-2005. I think this will be ready to commit once this change is made. Thanks!
ql/src/test/queries/clientpositive/udf_between.q
<https://reviews.apache.org/r/3008/#comment8915>
I'm not sure why you changed this testcase. The original version was better.
* The first two lines should be:
DESCRIBE FUNCTION between
DESCRIBE FUNCTION EXTENDED between;
* Please call EXPLAIN on each query before running it.
* Is there any reason in particular why you create the T1 table instead of reusing the 'src' table that gets created automatically for all CliDriver tests? Loading data will definitely make the test run more slowly.
- Carl
On 2011-12-16 02:09:08, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 02:09:08)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
(Updated 2011-12-16 02:09:08.375278)
Review request for hive, John Sichi and Carl Steinbach.
Changes
-------
Renamed 'btw' to 'between' as Carl mentioned.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs (updated)
-----
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out e63516d
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
> On 2011-12-15 08:06:32, Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g, line 2007
> > <https://reviews.apache.org/r/3008/diff/4/?file=63145#file63145line2007>
> >
> > I was able to get 'between' to work without 'btw' by adding KW_BETWEEN to the list of sysFuncNames below. Please see if you can get this to work too, and if so then remove any mention of 'btw' from the patch.
It's much better. Thanks.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3923
-----------------------------------------------------------
On 2011-12-08 04:21:44, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-08 04:21:44)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3923
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/3008/#comment8860>
I was able to get 'between' to work without 'btw' by adding KW_BETWEEN to the list of sysFuncNames below. Please see if you can get this to work too, and if so then remove any mention of 'btw' from the patch.
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/3008/#comment8859>
Add KW_BETWEEN to the list of sysFuncNames here.
- Carl
On 2011-12-08 04:21:44, Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3008/
> -----------------------------------------------------------
>
> (Updated 2011-12-08 04:21:44)
>
>
> Review request for hive, John Sichi and Carl Steinbach.
>
>
> Summary
> -------
>
> Revised version using 'between' UDF
>
>
> This addresses bug HIVE-2005.
> https://issues.apache.org/jira/browse/HIVE-2005
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
> ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out e63516d
> ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3008/diff
>
>
> Testing
> -------
>
> added new test : udf_between.q
>
>
> Thanks,
>
> Navis
>
>
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
(Updated 2011-12-08 04:21:44.611068)
Review request for hive, John Sichi and Carl Steinbach.
Changes
-------
Now we can use expression (exactly, precedenceBitwiseOrExpression) for target/min/max condition.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out e63516d
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
(Updated 2011-12-07 07:43:39.996429)
Review request for hive, John Sichi and Carl Steinbach.
Changes
-------
1. naming 'between' made exception.
2. added ASF License header.
3. result of show_functions.q has additional function named 'union_map'. it's not mine.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs (updated)
-----
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out e63516d
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis
Re: Review Request: HIVE-2005 Implement BETWEEN operator
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/
-----------------------------------------------------------
(Updated 2011-12-06 00:17:31.391722)
Review request for hive, John Sichi and Carl Steinbach.
Changes
-------
result of test 'show_functions.q' has changed also.
Summary
-------
Revised version using 'between' UDF
This addresses bug HIVE-2005.
https://issues.apache.org/jira/browse/HIVE-2005
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c7342c8
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 05b784b
ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/3008/diff
Testing
-------
added new test : udf_between.q
Thanks,
Navis