You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/20 02:26:55 UTC

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

wgy8283335 commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560631305



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
     ;
 
 dropTable
-    : DROP TABLE tableName
+    : DROP TABLE (schemaName DOT_)? tableName (CASCADE CONSTRAINTS)? (PURGE)?

Review comment:
       I am wondering whether need add "(schemaName DOT_)?",  as tableName definition is below:
   ```
   tableName
       : (owner DOT_)? name
   ```
   @tristaZero I think it's better to remove  "(schemaName DOT_)?", are you agree with me?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org