You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:58:11 UTC
[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #2044: Add note_syscall args support
YuuichiNakamura opened a new pull request #2044:
URL: https://github.com/apache/incubator-nuttx/pull/2044
## Summary
Add the option for syscall instrumentation to save arguments passed to syscalls
## Impact
- `struct note_syscall_enter_s` will be changed to keep argc and args.
- `trace mode +a` command will be added to enable the feature
## Testing
spesense:smp
When the feature is enabled, `trace dump` can show what arguments are passed to syscalls as follows:
```
trace-7 [0] 8.060000000: sys_open(arg0: 0xd01aa54, arg1: 0x0, arg2: 0x1)
trace-7 [0] 8.060000000: sys_open -> 0x3
trace-7 [0] 8.060000000: sys_nxsched_get_streams()
trace-7 [0] 8.060000000: sys_nxsched_get_streams -> 0xd02bfcc
trace-7 [0] 8.060000000: sys_ioctl(arg0: 0x3, arg1: 0x2c01, arg2: 0xd02c888)
trace-7 [0] 8.060000000: sys_ioctl -> 0x0
trace-7 [0] 8.060000000: sys_ioctl(arg0: 0x3, arg1: 0x2c02, arg2: 0xd02c888)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2044: Add note_syscall args support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2044:
URL: https://github.com/apache/incubator-nuttx/pull/2044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2044: Add note_syscall args support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2044:
URL: https://github.com/apache/incubator-nuttx/pull/2044#issuecomment-712865983
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2044: Add note_syscall args support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2044:
URL: https://github.com/apache/incubator-nuttx/pull/2044#discussion_r508319024
##########
File path: sched/Kconfig
##########
@@ -1009,6 +1009,7 @@ config SCHED_INSTRUMENTATION_FILTER_DEFAULT_MODE
Bit 0 = Enable instrumentation
Bit 1 = Enable syscall instrumentation
Bit 2 = Enable IRQ instrumentation
+ Bit 3 = Enable collecting syscall arguments
Review comment:
should we change the default to 0xf? other change looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org