You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2018/02/16 23:12:55 UTC

[GitHub] flink issue #5501: [FLINK-6053][metrics] Add new Number-/StringGauge metric ...

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5501
  
    LGTM generally.
    
    I still feel having all the `instanceof` in `notifyOfAddedMetric` and `notifyOfRemovedMetric` is a bit inelegant. I'm fine with it since there'll (hopefully) be only a limited number of metric types, so the `instanceof` clauses won't grow insanely.
    



---