[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #916: arch/arm/src/common/up_exit.c: _exit should call arm_fullcontextresto…

[GitBox <gi...@apache.org>]

liuguo09 opened a new pull request #916:
URL: https://github.com/apache/incubator-nuttx/pull/916


   …re for armv8-m
   
   Since armv8-m now uses arm_fullcontextrestore instead of up_fullcontextrestore, _exit
   should call arm_fullcontextrestore for armv8-m accordingly.
   
   Signed-off-by: liuhaitao <li...@xiaomi.com>
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #916: arch/arm/src/common/up_exit.c: _exit should call arm_fullcontextresto…

[GitBox <gi...@apache.org>]

patacongo commented on pull request #916:
URL: https://github.com/apache/incubator-nuttx/pull/916#issuecomment-621985591


   This change is incorrect.  arm_fullcontextrestore is the correct anem for the ARM-private function.  The name up_fullcontextrestore is incorrect and must be removed and replaced with arm_fullcontestrestore.  That is the requirement of the naming convention here:  https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ
   
   I have submitted PR #924 which replaces and correct this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org