You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Tom Barber <to...@meteorite.bi> on 2013/08/28 17:35:32 UTC
Fix for OODT-473
Hey guys
Looking through the stupidly easy Jira section whilst still getting my
head around the components and setup. Attached a patch to
https://issues.apache.org/jira/browse/OODT-473 to remove the delete
method, I hope its right, the test suite looks okay. I'm not sure about
SVN etiquette and generally if I'm doing the right thing, so I'll
probably just continue adding patches to Jira for now :)
Re: Fix for OODT-473
Posted by "Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov>.
Hi Tom,
I granted you JIRA karma so you should be able to assign OODT-460
to you :)
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Tom Barber <to...@meteorite.bi>
Reply-To: "dev@oodt.apache.org" <de...@oodt.apache.org>
Date: Wednesday, August 28, 2013 8:52 AM
To: "dev@oodt.apache.org" <de...@oodt.apache.org>
Subject: Re: Fix for OODT-473
>Thanks Chris,
>
>A few other things, can you assign OODT-460 to me unless someone else
>wants it, as I've got experience with that type of stuff with my day job
>so I may as well do it.
>
>Also I saw that cas-curator doesn't have any unit tests in the webapp,
>is that because it doesn't require any or they just didn't get written?
>
>Slowly getting my head wrapped around at least the main ingestion
>components :)
>
>Also anyone got an up to date component diagram, I'd like to extend
>something and put something on the wiki so newbs like myself understand
>how stuff hangs togther and their purpose (I still dont know what most
>of the modules do :) )
>
>Tom
>
>On 28/08/13 16:42, Mattmann, Chris A (398J) wrote:
>> Thanks Tom.
>>
>> Don't worry about the etiquette, if it's been sitting for a while,
>> patches *and* commits, welcome! :) Also if you'd like feel free to
>> use Review Board and then just say if there are no comments e.g.,
>> within 24, 48, 72 hours, etc., I'm going to go ahead and commit.
>>
>> Review Board is here: http://reviews.apache.org/
>>
>> Cheers,
>> Chris
>>
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> Chris Mattmann, Ph.D.
>> Senior Computer Scientist
>> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
>> Office: 171-266B, Mailstop: 171-246
>> Email: chris.a.mattmann@nasa.gov
>> WWW: http://sunset.usc.edu/~mattmann/
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> Adjunct Assistant Professor, Computer Science Department
>> University of Southern California, Los Angeles, CA 90089 USA
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>>
>>
>>
>>
>>
>> -----Original Message-----
>> From: Tom Barber <to...@meteorite.bi>
>> Reply-To: "dev@oodt.apache.org" <de...@oodt.apache.org>
>> Date: Wednesday, August 28, 2013 8:35 AM
>> To: "dev@oodt.apache.org" <de...@oodt.apache.org>
>> Subject: Fix for OODT-473
>>
>>> Hey guys
>>>
>>> Looking through the stupidly easy Jira section whilst still getting my
>>> head around the components and setup. Attached a patch to
>>> https://issues.apache.org/jira/browse/OODT-473 to remove the delete
>>> method, I hope its right, the test suite looks okay. I'm not sure about
>>> SVN etiquette and generally if I'm doing the right thing, so I'll
>>> probably just continue adding patches to Jira for now :)
>
Re: Fix for OODT-473
Posted by Tom Barber <to...@meteorite.bi>.
Thanks Chris,
A few other things, can you assign OODT-460 to me unless someone else
wants it, as I've got experience with that type of stuff with my day job
so I may as well do it.
Also I saw that cas-curator doesn't have any unit tests in the webapp,
is that because it doesn't require any or they just didn't get written?
Slowly getting my head wrapped around at least the main ingestion
components :)
Also anyone got an up to date component diagram, I'd like to extend
something and put something on the wiki so newbs like myself understand
how stuff hangs togther and their purpose (I still dont know what most
of the modules do :) )
Tom
On 28/08/13 16:42, Mattmann, Chris A (398J) wrote:
> Thanks Tom.
>
> Don't worry about the etiquette, if it's been sitting for a while,
> patches *and* commits, welcome! :) Also if you'd like feel free to
> use Review Board and then just say if there are no comments e.g.,
> within 24, 48, 72 hours, etc., I'm going to go ahead and commit.
>
> Review Board is here: http://reviews.apache.org/
>
> Cheers,
> Chris
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Senior Computer Scientist
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 171-266B, Mailstop: 171-246
> Email: chris.a.mattmann@nasa.gov
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Assistant Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>
>
>
>
> -----Original Message-----
> From: Tom Barber <to...@meteorite.bi>
> Reply-To: "dev@oodt.apache.org" <de...@oodt.apache.org>
> Date: Wednesday, August 28, 2013 8:35 AM
> To: "dev@oodt.apache.org" <de...@oodt.apache.org>
> Subject: Fix for OODT-473
>
>> Hey guys
>>
>> Looking through the stupidly easy Jira section whilst still getting my
>> head around the components and setup. Attached a patch to
>> https://issues.apache.org/jira/browse/OODT-473 to remove the delete
>> method, I hope its right, the test suite looks okay. I'm not sure about
>> SVN etiquette and generally if I'm doing the right thing, so I'll
>> probably just continue adding patches to Jira for now :)
Re: Fix for OODT-473
Posted by "Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov>.
Thanks Tom.
Don't worry about the etiquette, if it's been sitting for a while,
patches *and* commits, welcome! :) Also if you'd like feel free to
use Review Board and then just say if there are no comments e.g.,
within 24, 48, 72 hours, etc., I'm going to go ahead and commit.
Review Board is here: http://reviews.apache.org/
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Tom Barber <to...@meteorite.bi>
Reply-To: "dev@oodt.apache.org" <de...@oodt.apache.org>
Date: Wednesday, August 28, 2013 8:35 AM
To: "dev@oodt.apache.org" <de...@oodt.apache.org>
Subject: Fix for OODT-473
>Hey guys
>
>Looking through the stupidly easy Jira section whilst still getting my
>head around the components and setup. Attached a patch to
>https://issues.apache.org/jira/browse/OODT-473 to remove the delete
>method, I hope its right, the test suite looks okay. I'm not sure about
>SVN etiquette and generally if I'm doing the right thing, so I'll
>probably just continue adding patches to Jira for now :)