[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790154552



##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
 rust-version = "1.58"
 
 [dependencies]
-clap = "2.33"
+clap = "3.0"

Review comment:
       I can understand why I got the error
   ```
   ➜  datafusion-cli git:(update_dep) ✗ cargo build
      Compiling clap v3.0.10
      Compiling datafusion-cli v5.1.0 (/Users/bytedance/arrow-datafusion/datafusion-cli)
   error[E0432]: unresolved import `clap::crate_version`
     --> datafusion-cli/src/main.rs:18:12
      |
   18 | use clap::{crate_version, App, Arg};
      |            ^^^^^^^^^^^^^ no `crate_version` in the root
   
   error: cannot determine resolution for the macro `crate_version`
     --> datafusion-cli/src/main.rs:36:18
      |
   36 |         .version(crate_version!())
      |                  ^^^^^^^^^^^^^
      |
      = note: import resolution is stuck, try simplifying macro imports
   
   For more information about this error, try `rustc --explain E0432`.
   error: could not compile `datafusion-cli` due to 2 previous errors
   ```
   cc @alamb 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org