You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2025/10/09 20:24:12 UTC
[PR] Fix `concat_elements_utf8view` capacity initialization. [datafusion]
samueleresca opened a new pull request, #18003:
URL: https://github.com/apache/datafusion/pull/18003
## Which issue does this PR close?
- Partially closes #17857 (See https://github.com/apache/datafusion/issues/17857#issuecomment-3368519097)
## Rationale for this change
The capacity calculation replaced with `left.len()` (assuming `left.len()` and `right.len()` are the same). As the `with_capacity` refers to the length of the views (or strings), not to the length of the bytes
## Are these changes tested?
The function is already covered by tests.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `concat_elements_utf8view` capacity initialization. [datafusion]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #18003:
URL: https://github.com/apache/datafusion/pull/18003#issuecomment-3417104461
> LGTM, that capacity initialization was wrong. It is unrelated to the overflow issue though, right?
Yeah, this is unrelated to the overflow issue fix. AFAIU, it would just avoid allocating unneeded memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `concat_elements_utf8view` capacity initialization. [datafusion]
Posted by "ctsk (via GitHub)" <gi...@apache.org>.
ctsk commented on PR #18003:
URL: https://github.com/apache/datafusion/pull/18003#issuecomment-3400225876
LGTM, that capacity initialization was wrong. It is unrelated to the overflow issue though, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix `concat_elements_utf8view` capacity initialization. [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #18003:
URL: https://github.com/apache/datafusion/pull/18003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org