You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2016/11/18 15:30:08 UTC
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5139
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Kudu commit cd40d1c5126d0fd541d95370cdb2998b60f2f82c added a
call to sasl_set_mutex, which ends up in the client process
(Impala). That conflicts with Impala's SASL initialization code
resulting in a crash when the Kudu client is used to
open a connection to Kudu.
Kudu commit f2aeba6c059ea61f9cf8984d3e84d6c27b64d463
provided a method to disable the Kudu client's SASL
initialization to avoid this. This commit calls this method
on process startup.
Testing on kerberized cluster which was previously crashing.
Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
---
M be/src/common/init.cc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5139/1
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 4: Code-Review+2
carrying +2, rebased
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:
PS2, Line 617: kudu::client::DisableSaslInitialization();
> What guarantees that the Kudu client hasn't already initialized Sasl?
Kudu won't init sasl until a kudu client is created and connects to a master. So this is safe, but it looks like this call actually returns an error status if that's the case. I'll add a comment handle that.
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Kudu commit cd40d1c5126d0fd541d95370cdb2998b60f2f82c added a
call to sasl_set_mutex, which ends up in the client process
(Impala). That conflicts with Impala's SASL initialization code
resulting in a crash when the Kudu client is used to
open a connection to Kudu.
Kudu commit f2aeba6c059ea61f9cf8984d3e84d6c27b64d463
provided a method to disable the Kudu client's SASL
initialization to avoid this. This commit calls this method
on process startup.
Testing on kerberized cluster which was previously crashing.
Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Reviewed-on: http://gerrit.cloudera.org:8080/5139
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/rpc/authentication.cc
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 4: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/504/
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:
PS2, Line 617: kudu::client::DisableSaslInitialization();
What guarantees that the Kudu client hasn't already initialized Sasl?
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 3:
gvm failed because it needs to go in after the change the bumps the kudu version, which is still in gvo.
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 4: -Verified
Looks like I can't, so I'll run it through gvo again anyway.
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 4: Verified+1
Build failed with 'table already exists' bug - IMPALA-3641
Everything else passed, and I have run this on a secure cluster as well so I'm going to push the fix because I need to get this in for the KImpala 1.1 release which is waiting on this.
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 3: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/503/
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has uploaded a new patch set (#3).
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Kudu commit cd40d1c5126d0fd541d95370cdb2998b60f2f82c added a
call to sasl_set_mutex, which ends up in the client process
(Impala). That conflicts with Impala's SASL initialization code
resulting in a crash when the Kudu client is used to
open a connection to Kudu.
Kudu commit f2aeba6c059ea61f9cf8984d3e84d6c27b64d463
provided a method to disable the Kudu client's SASL
initialization to avoid this. This commit calls this method
on process startup.
Testing on kerberized cluster which was previously crashing.
Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
---
M be/src/rpc/authentication.cc
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5139/3
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
......................................................................
IMPALA-4497: Fix Kudu client crash w/ SASL initialization
Kudu commit cd40d1c5126d0fd541d95370cdb2998b60f2f82c added a
call to sasl_set_mutex, which ends up in the client process
(Impala). That conflicts with Impala's SASL initialization code
resulting in a crash when the Kudu client is used to
open a connection to Kudu.
Kudu commit f2aeba6c059ea61f9cf8984d3e84d6c27b64d463
provided a method to disable the Kudu client's SASL
initialization to avoid this. This commit calls this method
on process startup.
Testing on kerberized cluster which was previously crashing.
Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
---
M be/src/rpc/authentication.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5139/2
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>