You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/02 13:59:34 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4740: get_bridge_physdev returns "device:" instead of "device"
GabrielBrascher opened a new pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740
### Description
When running [get_bridge_physdev(brname)](https://github.com/apache/cloudstack/blob/b2ffa3efa58a1569dbaa8a34f723756926e22820/scripts/vm/network/security_group.py#L152) from `security_group.py` it is returned the bridge device as `brname:` instead of the expected `brname`.
We experienced this issue on CloudStack 4.13.1.0 with _Security Groups_ enabled for _Advanced Networking_. Additionally, KVM nodes are running on Ubuntu 18.04.
PR #4303 (merged in 4.15) added support for Ubuntu 20.04 which turned out to fix `get_bridge_physdev(brname)`; however, we faced the very same issue with the previous CloudStack and Ubuntu versions.
Even though we might not get a `4.13.2`, and CloudStack `4.14.1.0` has just been released, this PR proposes merging the fix into branch `4.13` and then get it forwarded into `4.14`. Thus, allowing users to have this fix referenced and also opening the possibility of addressing this in case of a potential `4.14.2.0`.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
We had manually changed the `security_group.py` script on our KVM nodes. All is working fine after applying this change.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789606453
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789697081
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789622510
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-788949955
@GabrielBrascher
should the target be 4.13 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789697569
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789590595
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789608930
@wido a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-788964409
Thanks for the ping @weizhouapache, updated base branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789590400
Thanks for submitting @GabrielBrascher @wido and sharing under which circumstances this happens. Is this a case specific to VXLAN or VLAN as well? (agnostic of isolation method)
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789575625
@rhtyd I would like to stress that this issue also occurs on Ubuntu 18.04 systems and not only on 20.04 as @weizhouapache mentioned in the original commit.
Two Ubuntu 18.04 systems running with VXLAN:
<pre>
root@hv-138-e14-33:~# bridge -o link show | grep vxlan500
28: vxlan500 state UNKNOWN : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master brvx-500 state forwarding priority 32 cost 100
</pre>
<pre>
root@hv-138-e14-25:~# bridge -o link show | grep vxlan500
9: vxlan500: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master brvx-500 state forwarding priority 32 cost 100
</pre>
I checked their kernels:
<pre>
Linux hv-138-e14-33.ams02.cldin.net 5.4.0-60-generic
Linux hv-138-e14-25.ams02.cldin.net 5.4.0-66-generic
Distributor ID: Ubuntu
Description: Ubuntu 18.04.5 LTS
Release: 18.04
Codename: bionic
</pre>
This causes Instance to **loose** their network connectivity after a initial boot or migration.
A very small fix which prevents major issues for (end-)users.
I would urge to merge this in 4.13 and then 4.14 so that we can release 4.14.2 with this fix in there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789591308
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-790463153
Test failures seem unrelated with the change, which is SG only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-790129283
<b>Trillian test result (tid-3645)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33630 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4740-t3645-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 168.64 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 165.56 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 220.48 | test_privategw_acl.py
test_01_migrate_VM_and_root_volume | `Error` | 52.84 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 46.88 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740#issuecomment-789608331
> Thanks for submitting @GabrielBrascher @wido and sharing under which circumstances this happens. Is this a case specific to VXLAN or VLAN as well? (agnostic of isolation method)
> @blueorangutan package
I think it's agnostic for the isolation method as these are just Linux bridges.
Deeper inside the kernel there is the knowledge if this is VXLAN or not, but the *bridge* util just outputs information from the Linux bridges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4740: get_bridge_physdev returns "device:" instead of "device"
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4740:
URL: https://github.com/apache/cloudstack/pull/4740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org