You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lucky-chen <gi...@git.apache.org> on 2018/05/03 12:15:30 UTC
[GitHub] incubator-weex pull request #1145: [WEEX-335][iOS] fix performance point && ...
GitHub user lucky-chen opened a pull request:
https://github.com/apache/incubator-weex/pull/1145
[WEEX-335][iOS] fix performance point && add errorType/errorGroup
1. rm useless code WXComponent+Layout.m (now .mm)
2. reportError with errorType and errorGroup
3. modify performance point
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucky-chen/incubator-weex ios-feature-gky
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1145
----
commit e79bad9b22cb189452312ab9bfdc8f3075d7ef76
Author: zhongcang <qh...@...>
Date: 2018-05-03T11:10:41Z
* [iOS] fix performance point && add emptyScreenCheck
* [iOS] fix performance report state
----
---
[GitHub] incubator-weex pull request #1145: [WEEX-335][iOS] fix performance point && ...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1145#discussion_r187253448
--- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.mm ---
@@ -163,6 +165,13 @@ - (NSUInteger)_childrenCountForLayout
- (void)_frameDidCalculated:(BOOL)isChanged
{
WXAssertComponentThread();
+ if (isChanged) {
+ CGFloat mainScreenWidth = [[UIScreen mainScreen] bounds].size.width;
+ CGFloat mainScreenHeight = [[UIScreen mainScreen] bounds].size.height;
+ if (mainScreenHeight/2 < _calculatedFrame.size.height && mainScreenWidth/2 < _calculatedFrame.size.width) {
+ [self weexInstance].performance.cellExceedNum++;
--- End diff --
they are not all cell components
---
[GitHub] incubator-weex pull request #1145: [WEEX-335][iOS] fix performance point && ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1145
---
[GitHub] incubator-weex issue #1145: [WEEX-335][iOS] fix performance point && add err...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1145
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---