You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "richardmilles (via GitHub)" <gi...@apache.org> on 2026/08/07 08:01:31 UTC

[PR] [Fix-18217][DataX] Escape single quotes in custom parameters [dolphinscheduler]

richardmilles opened a new pull request, #18466:
URL: https://github.com/apache/dolphinscheduler/pull/18466

   ## Was this PR generated or assisted by AI?
   
   YES. AI assistance was used for issue triage, drafting the change/test, and preparing the PR description. The fix logic and regression case were reviewed and verified against the reported failure mode (single quotes in DataX `-D` parameter values).
   
   ## Purpose of the pull request
   
   Fixes #18217
   
   When DataX custom parameter values contain single quotes (for example `AND create_data > '2026-05-06 10:59:09'`), `DataxTask#addCustomParameters` embeds them into the shell command without escaping. That breaks shell quoting and can cause DataX to mis-parse arguments.
   
   ## Brief change log
   
   - Escape `'` as `'\''` in custom parameter values before building the DataX `-p` shell fragment
   - Treat null parameter values as empty strings
   - Add a regression unit test covering a value with embedded single quotes
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - Added `DataxTaskTest#testBuildCommandEscapesSingleQuotesInCustomParameters`
   - Existing `DataxTaskTest#testHandleParamsMap` still covers quote-free values
   
   ## Pull Request Notice
   [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-18217][DataX] Escape single quotes in custom parameters [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #18466: [Fix-18217][DataX] Escape single quotes in custom parameters
URL: https://github.com/apache/dolphinscheduler/pull/18466


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-18217][DataX] Escape single quotes in custom parameters [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #18466:
URL: https://github.com/apache/dolphinscheduler/pull/18466#issuecomment-5215120522

   Please follow the pull request template first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix-18217][DataX] Escape single quotes in custom parameters [dolphinscheduler]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #18466:
URL: https://github.com/apache/dolphinscheduler/pull/18466#issuecomment-5214215365

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org