You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/22 02:03:26 UTC

[GitHub] [spark] peter-toth edited a comment on pull request #31913: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth edited a comment on pull request #31913:
URL: https://github.com/apache/spark/pull/31913#issuecomment-803548910


   The `Not(IsNull(e)) => IsNotNull(e)` and `Not(IsNotNull(e)) => IsNull(e)` optimizations were introduced in https://github.com/apache/spark/pull/25878 so the example query is a regression from 2.4 to 3.x, but I'm not sure that the issue doesn't come up in Spark 2.4 with other optimizations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org