You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/03/06 00:25:00 UTC

[GitHub] spark pull request #17159: [SPARK-19818][SparkR] rbind should check for name...

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17159#discussion_r104329881
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -2685,7 +2686,8 @@ setMethod("unionAll",
     
     #' Union two or more SparkDataFrames
     #'
    -#' Union two or more SparkDataFrames. This is equivalent to \code{UNION ALL} in SQL.
    +#' Union two or more SparkDataFrames by row. In constrast to \link{union}, this method
    +#' requires that the input SparkDataFrames have the same column names.
    --- End diff --
    
    I'd just say, `as in R's rbind, this method requires...`
    btw, should we care about data type matching - does R's rbind check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org