You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/22 06:29:46 UTC
[GitHub] [pulsar] Jennifer88huang opened a new pull request #7331: [doc] Refine link and heading issues in Pulsar metrics
Jennifer88huang opened a new pull request #7331:
URL: https://github.com/apache/pulsar/pull/7331
### Motivation
1. Broken links.
2. Incorrect headings.
### Modifications
Fix the link and incorrect heading issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7331: [doc] Refine link and heading issues in Pulsar metrics
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7331:
URL: https://github.com/apache/pulsar/pull/7331#discussion_r443354677
##########
File path: site2/docs/reference-metrics.md
##########
@@ -189,9 +185,9 @@ All the topic metrics are labelled with the following labels:
#### Replication metrics
-If a namespace that a topic belongs to is configured to be replicated between multiple Pulsar clusters, the corresponding replication metrics will also be exposed when `replicationMetricsEnabled` is enabled.
+If a namespace that a topic belongs to is configured to be replicated between multiple Pulsar clusters, the corresponding replication metrics is also exposed when `replicationMetricsEnabled` is enabled.
Review comment:
```suggestion
If a namespace that a topic belongs to is configured to be replicated among multiple Pulsar clusters, the corresponding replication metrics is also exposed when `replicationMetricsEnabled` is enabled.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang merged pull request #7331: [doc] Refine link and heading issues in Pulsar metrics
Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #7331:
URL: https://github.com/apache/pulsar/pull/7331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #7331: [doc] Refine link and heading issues in Pulsar metrics
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #7331:
URL: https://github.com/apache/pulsar/pull/7331#issuecomment-647314267
@Huanli-Meng could you please help review, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org