[GitHub] [tvm] Mousius commented on a change in pull request #8835: Change target string to Target object in the TE compiler and interpreter

[GitBox <gi...@apache.org>]

Mousius commented on a change in pull request #8835:
URL: https://github.com/apache/tvm/pull/8835#discussion_r695063391



##########
File path: src/relay/backend/build_module.cc
##########
@@ -491,8 +491,8 @@ class RelayBuildModule : public runtime::ModuleNode {
     auto lowered_funcs = executor_codegen_->GetIRModule();
 
     // No need to build for external functions.
-    if (lowered_funcs.find("ext_dev") != lowered_funcs.end()) {
-      lowered_funcs.Set("ext_dev", IRModule());
+    if (lowered_funcs.find(tvm::Target("ext_dev")) != lowered_funcs.end()) {
+      lowered_funcs.Set(tvm::Target("ext_dev"), IRModule());

Review comment:
       Yip! `Target("ext_dev")` is a magic target that turns up in a few places :smile_cat: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org