You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Merryle Wang via Review Board <no...@reviews.apache.org> on 2019/07/19 18:49:24 UTC

Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.


Repository: atlas


Description
-------

ATLAS-3343: Ordering of dynAttr evaluation


Diffs
-----

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 


Diff: https://reviews.apache.org/r/71127/diff/1/


Testing
-------

Created dummy dynamic attributes to test the correct ordering.


Thanks,

Merryle Wang

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Aadarsh Jajodia <aa...@gmail.com>.


> On July 23, 2019, 8:17 p.m., Aadarsh Jajodia wrote:
> > Can we use a simple adjacency list to represent the graph. Something like a Map<String, List<String> > to represent the graph. And also I feel we can just use a visited set and stack to maintain the topological order? Maybe that's simpler?

Also for the toplogocial sort using the stack, you could follow this approach.

void topologicalSort(string vertex) {
    visited.add(vertex);
    for (neighbor in vertex) {
        if(!visited[neighbor]) topologicalSort(neighbor)
    }
    stack.push(vertex);
}

We can pop all the elements in the stack and that should give the answer.


- Aadarsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review216812
-----------------------------------------------------------


On July 19, 2019, 6:49 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated July 19, 2019, 6:49 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/1/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Aadarsh Jajodia <aa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review216812
-----------------------------------------------------------



Can we use a simple adjacency list to represent the graph. Something like a Map<String, List<String> > to represent the graph. And also I feel we can just use a visited set and stack to maintain the topological order? Maybe that's simpler?

- Aadarsh Jajodia


On July 19, 2019, 6:49 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated July 19, 2019, 6:49 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/1/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Le Ma <co...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review216815
-----------------------------------------------------------

Hello Merryle, the toplogical sort algo is very nice done. I just have some questions about the in/outvertex and the bimap. Is the mapping from attr to index and index to attr needed here? Instead, you can use Map<Attr, List<Atrr>> adjList, a queue<Attr> and a inDegree array/map, and a result list to help you finish the sort:

1. traverse the input the attr list, maintain a key-value (attr and list of outVertex), for every outVertex we've met, incrase the inDegree array/map.
2. Once the traverse of the input attr arry is done, initialize a queue to maintain the starting point of your graph, travese the inDegree map, add any attributs which 
have 0 as its inDegree.
3. while(!queue.isEmpty()), poll out the attr inside the queue, add it to the result list, 
4. traverse it outVertex lists, for every outVertex, decrease its inDegree, and at the same time, check if the ingree is zore, if so, offer that attr into the queue.
5. Once done while-loop the queue, your result list will be the desire list, no sorting is needed. 

If you have questions, i am happy to discuss.

Thanks,
Le

- Le Ma

On July 19, 2019, 6:49 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated July 19, 2019, 6:49 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/1/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Le Ma <co...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review216838
-----------------------------------------------------------



Looks good to me. Nice done!

- Le Ma


On July 23, 2019, 11:22 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 11:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java c114bdf7888519cdd396fc8501bbcd92b00ef0bb 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/2/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review217069
-----------------------------------------------------------


Fix it, then Ship it!




nice work on the topological sorting!


intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 1008 (patched)
<https://reviews.apache.org/r/71127/#comment304323>

    createGraph() => createTokenAttributesMap()



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 1050 (patched)
<https://reviews.apache.org/r/71127/#comment304322>

    outVertex => tokenAttribute


- Sarath Subramanian


On July 25, 2019, 1:20 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated July 25, 2019, 1:20 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java c114bdf7888519cdd396fc8501bbcd92b00ef0bb 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/3/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review217091
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Aug. 5, 2019, 3:19 p.m., Merryle Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2019, 3:19 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3343: Ordering of dynAttr evaluation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java c114bdf7888519cdd396fc8501bbcd92b00ef0bb 
> 
> 
> Diff: https://reviews.apache.org/r/71127/diff/5/
> 
> 
> Testing
> -------
> 
> Created dummy dynamic attributes to test the correct ordering.
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>