You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/11 03:25:07 UTC

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #126: Prevent a segmentation fault during initialization

swebb2066 opened a new pull request, #126:
URL: https://github.com/apache/logging-log4cxx/pull/126

    This PR prevents a runtime crash when using a staticly linked log4cxx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] rm5248 commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1243013441

   Is this not currently caught by the static windows build that we do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] swebb2066 merged pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
swebb2066 merged PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] rm5248 commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1249820425

   The best place to get help would be to send a message to the mailing list(log4cxx-user@logging.apache.org)
   
   However if you are using vcpkg, you should just be able to create an overlay port to override the version that is in vcpkg, or modify vcpkg locally on your side.  This may help: https://devblogs.microsoft.com/cppblog/registries-bring-your-own-libraries-to-vcpkg/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] LeeGDavis commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
LeeGDavis commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1250001359

   That worked for us.  There was one problem with the portfile.cmake. I had to revert recent threadutility.cc changes and nuke linux.patch. Otherwise we are no longer segfaulting with this change.  We have yet to test all the functionality, but I look forward to getting our hands on this update.  Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] swebb2066 commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
swebb2066 commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1243070579

   master does not have that change to workflows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] LeeGDavis commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
LeeGDavis commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1249821967

   Thank you for the links @rm5248 !  I'll take a look to the mailing list moving forward too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] LeeGDavis commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
LeeGDavis commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1249795991

   I think I'm running into this. We're in the process of upgrading from 0.11 to 0.13 and encountering a segfault on initialization. Is there anyway I can test this with my application using vcpkg and report back? Also If I shouldn't be posting here, please advise. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4cxx] rm5248 commented on pull request #126: Prevent a segmentation fault during initialization

Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #126:
URL: https://github.com/apache/logging-log4cxx/pull/126#issuecomment-1243103721

   next_stable does have that change though.  It looks like the build is performed, but the since the tests aren't run with the static build any runtime error would not show up.
   
   I think that we want to split out the build and test of a static build into a separate workflow so we can catch this if it fails again.
   
   Otherwise this looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org