You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/03/08 16:04:17 UTC

Review Request 57423: Stack Upgrade tests fail during Hive Metastore restart due to missing hive-site.jceks file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57423/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-20361
    https://issues.apache.org/jira/browse/AMBARI-20361


Repository: ambari


Description
-------

During an upgrade, Hive Metastore restart fails because of

```
  File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py", line 228, in hive
    params.user_group
  File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/security_commons.py", line 55, in update_credential_provider_path
    content = StaticFile(src_provider_path)
...
resource_management.core.exceptions.Fail: StaticFile('/usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks') Source file /usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks is not found
```

This is due to the file permissions of 640 of the JCEKS file. The StaticFile class uses sudo to read the content but not check for the file's existance.


Diffs
-----

  ambari-common/src/main/python/resource_management/core/source.py cee6f57 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py a101577 


Diff: https://reviews.apache.org/r/57423/diff/1/


Testing
-------

Existing errors are already on trunk.

----------------------------------------------------------------------
Total run:1192
Total errors:0
Total failures:2
ERROR
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.762 s
[INFO] Finished at: 2017-03-08T10:36:30-05:00
[INFO] Final Memory: 18M/310M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Re: Review Request 57423: Stack Upgrade tests fail during Hive Metastore restart due to missing hive-site.jceks file

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57423/#review168304
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On March 8, 2017, 4:04 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57423/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 4:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-20361
>     https://issues.apache.org/jira/browse/AMBARI-20361
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During an upgrade, Hive Metastore restart fails because of
> 
> ```
>   File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py", line 228, in hive
>     params.user_group
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/security_commons.py", line 55, in update_credential_provider_path
>     content = StaticFile(src_provider_path)
> ...
> resource_management.core.exceptions.Fail: StaticFile('/usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks') Source file /usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks is not found
> ```
> 
> This is due to the file permissions of 640 of the JCEKS file. The StaticFile class uses sudo to read the content but not check for the file's existance.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/source.py cee6f57 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py a101577 
> 
> 
> Diff: https://reviews.apache.org/r/57423/diff/1/
> 
> 
> Testing
> -------
> 
> Existing errors are already on trunk.
> 
> ----------------------------------------------------------------------
> Total run:1192
> Total errors:0
> Total failures:2
> ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.762 s
> [INFO] Finished at: 2017-03-08T10:36:30-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 57423: Stack Upgrade tests fail during Hive Metastore restart due to missing hive-site.jceks file

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57423/#review168424
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 8, 2017, 6:04 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57423/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-20361
>     https://issues.apache.org/jira/browse/AMBARI-20361
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During an upgrade, Hive Metastore restart fails because of
> 
> ```
>   File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py", line 228, in hive
>     params.user_group
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/security_commons.py", line 55, in update_credential_provider_path
>     content = StaticFile(src_provider_path)
> ...
> resource_management.core.exceptions.Fail: StaticFile('/usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks') Source file /usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks is not found
> ```
> 
> This is due to the file permissions of 640 of the JCEKS file. The StaticFile class uses sudo to read the content but not check for the file's existance.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/source.py cee6f57 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py a101577 
> 
> 
> Diff: https://reviews.apache.org/r/57423/diff/1/
> 
> 
> Testing
> -------
> 
> Existing errors are already on trunk.
> 
> ----------------------------------------------------------------------
> Total run:1192
> Total errors:0
> Total failures:2
> ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.762 s
> [INFO] Finished at: 2017-03-08T10:36:30-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 57423: Stack Upgrade tests fail during Hive Metastore restart due to missing hive-site.jceks file

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57423/#review168305
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On March 8, 2017, 11:04 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57423/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 11:04 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-20361
>     https://issues.apache.org/jira/browse/AMBARI-20361
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During an upgrade, Hive Metastore restart fails because of
> 
> ```
>   File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py", line 228, in hive
>     params.user_group
>   File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/security_commons.py", line 55, in update_credential_provider_path
>     content = StaticFile(src_provider_path)
> ...
> resource_management.core.exceptions.Fail: StaticFile('/usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks') Source file /usr/hdp/current/hive-metastore/conf/conf.server/hive-site.jceks is not found
> ```
> 
> This is due to the file permissions of 640 of the JCEKS file. The StaticFile class uses sudo to read the content but not check for the file's existance.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/source.py cee6f57 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py a101577 
> 
> 
> Diff: https://reviews.apache.org/r/57423/diff/1/
> 
> 
> Testing
> -------
> 
> Existing errors are already on trunk.
> 
> ----------------------------------------------------------------------
> Total run:1192
> Total errors:0
> Total failures:2
> ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.762 s
> [INFO] Finished at: 2017-03-08T10:36:30-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>