You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/22 16:26:10 UTC
[GitHub] [incubator-hudi] xushiyan opened a new pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
xushiyan opened a new pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553
WIP
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-619302731
@yanghua The PR is ready for review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io edited a comment on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-618814181
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=h1) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/19cc15c0987043175685aaeb45facb15af23e34f&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
- Coverage 71.66% 71.65% -0.02%
Complexity 294 294
============================================
Files 378 378
Lines 16551 16551
Branches 1670 1670
============================================
- Hits 11861 11859 -2
- Misses 3959 3961 +2
Partials 731 731
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/hudi/metrics/Metrics.java](https://codecov.io/gh/apache/incubator-hudi/pull/1553/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `56.75% <0.00%> (-10.82%)` | `0.00% <0.00%> (ø%)` | |
| [...a/org/apache/hudi/common/util/collection/Pair.java](https://codecov.io/gh/apache/incubator-hudi/pull/1553/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9QYWlyLmphdmE=) | `72.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1553/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `89.65% <0.00%> (+10.34%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=footer). Last update [19cc15c...b7fc271](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-619486621
@xushiyan There are some conflicting files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-618814181
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=h1) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/19cc15c0987043175685aaeb45facb15af23e34f&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
+ Coverage 71.66% 71.68% +0.01%
Complexity 294 294
============================================
Files 378 378
Lines 16551 16551
Branches 1670 1670
============================================
+ Hits 11861 11864 +3
+ Misses 3959 3956 -3
Partials 731 731
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1553/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `89.65% <0.00%> (+10.34%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=footer). Last update [19cc15c...79e937d](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] yanghua commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-618938010
@xushiyan If this PR is ready for review, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-620308695
@yanghua Fixed 2 new conflicts
hudi-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutor.java
hudi-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryQueue.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] xushiyan commented on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-619623525
> @xushiyan There are some conflicting files.
@yanghua ok fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io edited a comment on pull request #1553: [HUDI-810] Migrate ClientTestHarness to JUnit 5
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1553:
URL: https://github.com/apache/incubator-hudi/pull/1553#issuecomment-618814181
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=h1) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/19cc15c0987043175685aaeb45facb15af23e34f&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
+ Coverage 71.66% 71.68% +0.01%
Complexity 294 294
============================================
Files 378 378
Lines 16551 16551
Branches 1670 1670
============================================
+ Hits 11861 11864 +3
+ Misses 3959 3956 -3
Partials 731 731
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1553/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `89.65% <0.00%> (+10.34%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=footer). Last update [19cc15c...79e937d](https://codecov.io/gh/apache/incubator-hudi/pull/1553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org