You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Pankraz76 (via GitHub)" <gi...@apache.org> on 2025/05/18 21:58:45 UTC
[PR] Unused assignment [maven]
Pankraz76 opened a new pull request, #2350:
URL: https://github.com/apache/maven/pull/2350
- https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#unnecessaryfullyqualifiedname
- https://github.com/apache/maven/pull/2331
- UnusedAssignment
<img width="380" alt="image" src="https://github.com/user-attachments/assets/e299ca40-40dc-470f-aff1-792b7bfb3413" />
<img width="1815" alt="image" src="https://github.com/user-attachments/assets/18441a8d-79cd-4c93-aed1-d76103575889" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UnusedAssignment [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #2350:
URL: https://github.com/apache/maven/pull/2350#discussion_r2112399079
##########
compat/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java:
##########
@@ -30,9 +30,9 @@
public class MetadataGraphEdge {
String version;
ArtifactScopeEnum scope;
- int depth = -1;
- int pomOrder = -1;
- boolean resolved = true;
+ int depth;
Review Comment:
thanks for advisory. Will undo and dedication to each concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UnusedAssignment [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 closed pull request #2350: UnusedAssignment
URL: https://github.com/apache/maven/pull/2350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UnusedAssignment [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2350:
URL: https://github.com/apache/maven/pull/2350#issuecomment-2890931080
maybe flaky:
Caused by: org.apache.maven.api.services.ArtifactResolverException: The following artifacts could not be resolved: eu.maveniverse.maven.parent:parent:pom:28 (absent): Could not transfer artifact eu.maveniverse.maven.parent:parent:pom:28 from/to central (https://repo.maven.apache.org/maven2): HTTP connect timed out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UnusedAssignment [maven]
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie commented on code in PR #2350:
URL: https://github.com/apache/maven/pull/2350#discussion_r2096701934
##########
compat/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java:
##########
@@ -30,9 +30,9 @@
public class MetadataGraphEdge {
String version;
ArtifactScopeEnum scope;
- int depth = -1;
- int pomOrder = -1;
- boolean resolved = true;
+ int depth;
Review Comment:
removing those is wrong. Currently, calling "getPomOrder()" in a subclass constructor (which is called from super()) will return -1. After this change, it will return 0.
This is not just a simple cleanup, but changing the actual logic of the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org