[GitHub] [skywalking-php] wu-sheng commented on a diff in pull request #64: Add amqplib plugin for producer.

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #64:
URL: https://github.com/apache/skywalking-php/pull/64#discussion_r1164884989


##########
README.md:
##########
@@ -33,6 +33,7 @@ SkyWalking PHP Agent requires SkyWalking 8.4+ and PHP 7.2+
   * [ ] [php-amqp](https://github.com/php-amqp/php-amqp)
   * [ ] [php-rdkafka](https://github.com/arnaud-lb/php-rdkafka)
   * [x] [predis](https://github.com/predis/predis)
+  * [x] [php-amqplib](https://github.com/php-amqplib/php-amqplib)

Review Comment:
   If you need a general type for `amqp`, you have to register it here, https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml
   
   Also, you may need mapping to indicate it is a queue server(without a specific MQ type), or an icon for topology.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org